-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial version of modified Send To button #2613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is functional but the button on Mac still doesn't look very nice |
When switching perspectives the error is thrown:
|
Now the error is:
|
wpotrzebowski
approved these changes
Sep 22, 2023
Since @wpotrzebowski's observation is not directly related to this PR, can it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let's have people look at this redesign and express their opinions on functionality/look.
This PR is for a small change in what the "Send to" button looks like and behaves. QPushButton has been replaced with QToolButton, with drop down menu.
The original functionality is retained - just clicking the button will send the selected dataset(s) to new tab(s) in fitting.
Clicking on the arrow in the right bottom corner of the Send To button will open a small menu allowing users to replace the data with the current dataset instead. This mimicks the "swap" button and slightly declutters the area.