Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial version of modified Send To button #2613

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Conversation

rozyczko
Copy link
Member

Description

Let's have people look at this redesign and express their opinions on functionality/look.

This PR is for a small change in what the "Send to" button looks like and behaves. QPushButton has been replaced with QToolButton, with drop down menu.
The original functionality is retained - just clicking the button will send the selected dataset(s) to new tab(s) in fitting.
Clicking on the arrow in the right bottom corner of the Send To button will open a small menu allowing users to replace the data with the current dataset instead. This mimicks the "swap" button and slightly declutters the area.

Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality works fine. I haven't looked at the code yet.

The GUI on Mac can potentially be improved
Screenshot 2023-09-18 at 14 19 06

@wpotrzebowski
Copy link
Contributor

It is functional but the button on Mac still doesn't look very nice

@wpotrzebowski
Copy link
Contributor

Looks better but can probably be improved
Screenshot 2023-09-21 at 18 26 53

@wpotrzebowski
Copy link
Contributor

When switching perspectives the error is thrown:

09:44:22 - ERROR: Traceback (most recent call last):
  File "sas/qtgui/MainWindow/DataExplorer.py", line 1045, in updatePerspectiveCombo
  File "sas/qtgui/MainWindow/DataExplorer.py", line 1026, in sendToMenu
RuntimeError: Failed to disconnect signal triggered().

@wpotrzebowski
Copy link
Contributor

Now the error is:

17:19:12 - ERROR: Traceback (most recent call last):
  File "sas/qtgui/Perspectives/Fitting/FittingWidget.py", line 3208, in complete1D
  File "sas/qtgui/Perspectives/Fitting/FittingWidget.py", line 3332, in calculateResiduals
  File "sas/qtgui/Perspectives/Fitting/FittingUtilities.py", line 438, in calculateChi2
ValueError: operands could not be broadcast together with shapes (192,) (0,)

@rozyczko
Copy link
Member Author

Since @wpotrzebowski's observation is not directly related to this PR, can it be merged?

@wpotrzebowski wpotrzebowski merged commit f06d3e6 into main Sep 25, 2023
36 checks passed
@wpotrzebowski wpotrzebowski deleted the improved_sendto branch September 25, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants