-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further tweaks to Basic-1D-Fitting tutorials #21
Conversation
I am confused. I see that the typo seems to have been fixed and the red line on the residual plot properly assigned to +/- 3 instead of 2, but otherwise it looks like the 6.0 version is an update to an old version of the tutorial for 6.0? The plots are now back to being the ones from b1 (without the new logo) and the text around example 2 looks like it did before it was changed to reflect the currently agreed results (chi^2 less than 1 and vol frac of order 17%). Were the wrong versions uploaded as "new?" or the wrong versions used as the starting point to do "further tweaks?" or am I misunderstanding or misremembering? |
Sorry, I didn't have time to look at it and decided that I will stick with the previous version (that I uploaded to sasview.org). Now, I see that probably better to wait with reviewing. Two comments from students (to the previous version)
Definitely not for this PR but I am thinking that providing project files that will cover tutorials content maybe not a bad idea. In most cases, I was able to rescue students if they fit went very wrong but it may be easier to have a such recovery states. |
@butlerpd wrote:
Ahem. Umm. Yes! Whoops-a-daisy! Re-doing them now. |
@wpotrzebowski wrote:
Ooo, good catch! Thanks! The
A few lines lower on the same page as the now removed Calculate I have changed it to read:
Done. |
In #14 (comment) @butlerpd wrote:
The screenshots have now also been re-done at the same resolution and in the same way as those in the v6 document. |
I haven't read the entire thing but I looked at the latest changes (since I read it last). They look good. |
Agreed at Leadership Team meeting 15/10/24 to merge this without further review. |
This PR addresses the tweaks suggested by @butlerpd in #14 (comment).