Skip to content

Commit

Permalink
Tweaks layout and styling for new default exploredata view (#3477)
Browse files Browse the repository at this point in the history
# Description and Motivation
<!--- bulleted, high level items. use keywords (eg "closes #144" or
"fixes #4323") -->

- cleanup tailwind classes
- split up into multiple component files for clarity
- closes #3472
- smaller vertical padding around card titles on mobile
- making the image and title linkable
- reconfigure vscode biome



## Has this been tested? How?

tests passing

## Screenshots (if appropriate)

<img width="1454" alt="Screenshot 2024-07-18 at 3 05 28 PM"
src="https://github.com/user-attachments/assets/087049b3-dd90-49b0-84d1-ec5f4b2fdd43">
<img width="1454" alt="Screenshot 2024-07-18 at 3 05 34 PM"
src="https://github.com/user-attachments/assets/498364fb-88c0-47d3-8216-bcca36657b31">
<img width="697" alt="Screenshot 2024-07-18 at 3 06 12 PM"
src="https://github.com/user-attachments/assets/a72223e6-2e67-40e0-9a1c-4eae61dab37b">
<img width="697" alt="Screenshot 2024-07-18 at 3 06 19 PM"
src="https://github.com/user-attachments/assets/f98adf93-5f2d-4141-81d0-cfe7d575a92f">
<img width="697" alt="Screenshot 2024-07-18 at 3 06 43 PM"
src="https://github.com/user-attachments/assets/d393f07a-af84-4b3a-b448-75d6c070baa1">


## Types of changes

(leave all that apply)

- Bug fix
- Refactor / chore

## New frontend preview link is below in the Netlify comment 😎
  • Loading branch information
benhammondmusic authored Jul 19, 2024
1 parent 695b3f0 commit e7cdd5d
Show file tree
Hide file tree
Showing 23 changed files with 3,240 additions and 2,405 deletions.
21 changes: 14 additions & 7 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,26 @@
{
"editor.formatOnSave": true,
"cSpell.import": ["../cspell.config.json"],
"flake8.args": ["--max-line-length=120"],
"black-formatter.args": ["--line-length", "120"],
"cSpell.import": [
"../cspell.config.json"
],
"flake8.args": [
"--max-line-length=120"
],
"black-formatter.args": [
"--line-length",
"120"
],
"[javascript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[json]": {
"editor.defaultFormatter": "vscode.json-language-features"
"editor.defaultFormatter": "biomejs.biome"
},
"[typescript]": {
"editor.defaultFormatter": "vscode.typescript-language-features"
"editor.defaultFormatter": "biomejs.biome"
},
"[typescriptreact]": {
"editor.defaultFormatter": "vscode.typescript-language-features"
"editor.defaultFormatter": "biomejs.biome"
},
"[jsonc]": {
"editor.defaultFormatter": "biomejs.biome"
Expand Down Expand Up @@ -77,4 +84,4 @@
"mypy-type-checker.args": [
"\"--config-file=pyproject.toml\""
]
}
}
6 changes: 2 additions & 4 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"jsxQuoteStyle": "single",
"semicolons": "asNeeded",
"indentStyle": "space",
"indentWidth": 2,
"trailingComma": "es5"
"indentWidth": 2
}
},
"linter": {
Expand All @@ -41,8 +40,7 @@
"noInferrableTypes": "off",
"noParameterAssign": "off",
"noUselessElse": "off",
"useDefaultParameterLast": "off",
"useImportTypes": "off"
"useDefaultParameterLast": "off"
},
"complexity": {
"noForEach": "off",
Expand Down
Loading

0 comments on commit e7cdd5d

Please sign in to comment.