Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): fix video test and constraint #971

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Conversation

Flemmli97
Copy link
Contributor

What this PR does 📖

  • Testing vid errored due to invalid constraint. I cleaned it up a bit and removed the audio part which caused the error. We also do not need it anyway since that part is just video testing

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Dec 31, 2024
Copy link

github-actions bot commented Dec 31, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Dec 31, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@lgmarchi lgmarchi added the 🫡 Dev Approved Review Dev reviewed the code and approved it. label Jan 2, 2025
@stavares843 stavares843 merged commit 24efe74 into dev Jan 2, 2025
11 checks passed
@stavares843 stavares843 deleted the fix-video-test branch January 2, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🫡 Dev Approved Review Dev reviewed the code and approved it. Missing dev review Two dev reviews are required on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants