Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(raygun): use MessageOptions.limit when fetching messages #330

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

sdwoodbury
Copy link
Contributor

What this PR does 📖
if set, the limit will limit the number of messages yielded. This makes it easier to fetch the next X messages when scrolling up/down and makes it possible to fetch X messages before/after a pinned message.

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@sdwoodbury sdwoodbury self-assigned this Sep 29, 2023
Copy link
Contributor

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. In MessageOptions can we set range to None if a limit is set and vise versa? This would make sure there isnt any conflicting parts between limit and range

@dariusc93 dariusc93 merged commit 2ae7f38 into main Oct 4, 2023
@dariusc93 dariusc93 deleted the feat/limit-messages branch October 4, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants