Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Dont download attachment using constellation api #332

Merged
merged 2 commits into from
Oct 4, 2023
Merged

refactor: Dont download attachment using constellation api #332

merged 2 commits into from
Oct 4, 2023

Conversation

dariusc93
Copy link
Contributor

What this PR does 📖

  • Remove logic renaming incoming attachments
  • Change logic to download without using constellation api
  • Remove code that stores reference in constellation

Which issue(s) this PR fixes 🔨

N/A

Special notes for reviewers 🗒️

  • For the time being this will remove the logic that stores the file reference in constellation, but will be readded in the near future

Additional comments 🎤

@dariusc93 dariusc93 self-assigned this Oct 4, 2023
@dariusc93 dariusc93 marked this pull request as ready for review October 4, 2023 18:03
@dariusc93 dariusc93 merged commit 8bcb537 into main Oct 4, 2023
@dariusc93 dariusc93 deleted the refactor/download-attachment-logic branch October 4, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dariusc93 dariusc93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dariusc93