Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move conversation functionality into its own task #340

Merged
merged 11 commits into from
Oct 20, 2023

Conversation

dariusc93
Copy link
Contributor

@dariusc93 dariusc93 commented Oct 18, 2023

What this PR does 📖

  • Move some of the conversation logic into its own task
  • Remove individual pinning of messages and perform a recursive pin on the conversation
  • Move conversation list into its own document instead of individual documents
  • Map the conversation keystore into the root document

Which issue(s) this PR fixes 🔨

  • N/A

Special notes for reviewers 🗒️

  • This is a breaking change due to each conversation being pushed into its own document rather than individual documents. There is no migration path at this time to move those conversations into the single document

Additional comments 🎤

  • This may be changed to push the pointer into the root document of the identity to keep everything together, however performance may vary long term.
  • The whole keystore is linked to root document, but most may be invalidated in the future depending on if the conversations exist or persist.

@dariusc93 dariusc93 self-assigned this Oct 18, 2023
@dariusc93 dariusc93 marked this pull request as ready for review October 20, 2023 20:27
@dariusc93 dariusc93 merged commit 299da4a into main Oct 20, 2023
1 check passed
@dariusc93 dariusc93 deleted the chore/conversation-task branch October 20, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant