Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Split raw data from processing functions #348

Merged
merged 18 commits into from
Oct 27, 2023
Merged

chore: Split raw data from processing functions #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
197f08d
chore: Change logic to request events
dariusc93 Oct 24, 2023
909bd35
chore: Check connection prior to request any
dariusc93 Oct 24, 2023
f56bb2a
chore: Update test to add a logging subscriber
dariusc93 Oct 24, 2023
daca2c6
chore: Subscribe to logging for chat in test
dariusc93 Oct 24, 2023
385ec6b
chore: use try_init
dariusc93 Oct 25, 2023
547d614
chore: move phonebook initialization outside of `Identity`
dariusc93 Oct 25, 2023
5bab622
chore: Remove redundant behaviour
dariusc93 Oct 25, 2023
042f482
chore: Correct spelling in log
dariusc93 Oct 25, 2023
a04000e
chore: Reduce channel bounds to 0
dariusc93 Oct 25, 2023
01fe313
chore: Correct linting
dariusc93 Oct 25, 2023
da1a701
chore: Ignore non camel case types
dariusc93 Oct 26, 2023
dee553f
chore: Remove redundant cast
dariusc93 Oct 26, 2023
2c0eb09
chore: Linting
dariusc93 Oct 26, 2023
91aa528
chore: Additional logging
dariusc93 Oct 27, 2023
0e91a98
chore: Remove unused event
dariusc93 Oct 27, 2023
8b74da9
chore: Dont return error if identity is the same
dariusc93 Oct 27, 2023
6f01731
chore: Remove spawned task
dariusc93 Oct 27, 2023
66f754d
chore: Change return signature to remove bool
dariusc93 Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions extensions/warp-blink-wrtc/src/host_media/audio/opus/source/framer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ impl Framer {
let loudness_calculator = loudness::Calculator::new(frame_size);
let mut buf: Vec<f32> = Vec::new();
buf.reserve(frame_size);
let mut opus_out: Vec<u8> = Vec::new();
opus_out.resize(frame_size * 4, 0);
let opus_out: Vec<u8> = vec![0; frame_size * 4];
let mut encoder = opus::Encoder::new(
webrtc_codec.sample_rate(),
opus::Channels::Mono,
Expand Down
21 changes: 7 additions & 14 deletions extensions/warp-blink-wrtc/src/host_media/audio/opus/source/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,7 @@ mod test {
let mut buf1: Vec<f32> = Vec::new();
buf1.resize(buff_size, 0_f32);

let mut buf2: Vec<u8> = Vec::new();
buf2.resize(buff_size * 4, 0);
let mut buf2: Vec<u8> = vec![0; buff_size * 4];

encoder
.encode_float(buf1.as_slice(), buf2.as_mut_slice())
Expand All @@ -343,8 +342,7 @@ mod test {
let mut buf1: Vec<f32> = Vec::new();
buf1.resize(buff_size, 0_f32);

let mut buf2: Vec<u8> = Vec::new();
buf2.resize(buff_size * 4, 0);
let mut buf2: Vec<u8> = vec![0; buff_size * 4];

encoder
.encode_float(buf1.as_slice(), buf2.as_mut_slice())
Expand All @@ -359,8 +357,7 @@ mod test {
let mut buf1: Vec<f32> = Vec::new();
buf1.resize(buff_size, 0_f32);

let mut buf2: Vec<u8> = Vec::new();
buf2.resize(buff_size * 4, 0);
let mut buf2: Vec<u8> = vec![0; buff_size * 4];

encoder
.encode_float(buf1.as_slice(), buf2.as_mut_slice())
Expand All @@ -375,8 +372,7 @@ mod test {
let mut buf1: Vec<f32> = Vec::new();
buf1.resize(buff_size, 0_f32);

let mut buf2: Vec<u8> = Vec::new();
buf2.resize(buff_size * 4, 0);
let mut buf2: Vec<u8> = vec![0; buff_size * 4];

encoder
.encode_float(buf1.as_slice(), buf2.as_mut_slice())
Expand All @@ -391,8 +387,7 @@ mod test {
let mut buf1: Vec<f32> = Vec::new();
buf1.resize(buff_size, 0_f32);

let mut buf2: Vec<u8> = Vec::new();
buf2.resize(buff_size * 4, 0);
let mut buf2: Vec<u8> = vec![0; buff_size * 4];

encoder
.encode_float(buf1.as_slice(), buf2.as_mut_slice())
Expand All @@ -404,11 +399,9 @@ mod test {
let mut encoder =
opus::Encoder::new(48000, opus::Channels::Mono, opus::Application::Voip).unwrap();
let buff_size = 120;
let mut buf1: Vec<i16> = Vec::new();
buf1.resize(buff_size, 0);
let buf1: Vec<i16> = vec![0; buff_size];

let mut buf2: Vec<u8> = Vec::new();
buf2.resize(buff_size * 2, 0);
let mut buf2: Vec<u8> = vec![0; buff_size * 2];

encoder
.encode(buf1.as_slice(), buf2.as_mut_slice())
Expand Down
Loading