-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entity that reads filled searchbox on new and old hosts pages #1589
Add entity that reads filled searchbox on new and old hosts pages #1589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewisely looks good to me, one question - shouldn't this be always True
?
read_searchbox_value == 'some_search_string'
Or what should I expect to change here and why?
@vsedmik I don't know if I get your last comment, where do you specifically see usage of the |
@LadislavVasina1 I just meant the example you provided in the PR description
|
@vsedmik I made this read function for vijay so he has an easier job in his current work, if that's what you are asking |
def read_filled_searchbox(self): | ||
"""Read filled searchbox""" | ||
view = self.navigate_to(self, 'All') | ||
self.browser.plugin.ensure_page_safe(timeout='5s') | ||
view.wait_displayed() | ||
return view.searchbox.read() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are working absolutely fine, I tested it locally, and now running in CI as part of this robottelo PR SatelliteQE/robottelo#16641
These changes are here in another airgun PR #1593
) * Add entity that reads filled searchbox on new and old hosts pages * Change docstrings (cherry picked from commit 4cb153e)
) (#1594) * Add entity that reads filled searchbox on new and old hosts pages * Change docstrings (cherry picked from commit 4cb153e) Co-authored-by: Ladislav Vašina <[email protected]>
Add an entity
read_filled_searchbox
to thehost.py
(old hosts UI) andall_hosts.py
(new hosts UI) so that it can be used in the automation.Usage: