Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support for template sync #1621

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

lhellebr
Copy link
Contributor

@lhellebr lhellebr commented Nov 6, 2024

No description provided.

@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches 6.13.z 6.14.z 6.15.z 6.16.z No-CherryPick PR doesnt need CherryPick to previous branches and removed CherryPick PR needs CherryPick to previous branches 6.13.z 6.14.z 6.15.z 6.16.z labels Nov 6, 2024
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lhellebr lhellebr requested review from pnovotny and pondrejk November 7, 2024 10:14
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewisely looks ok. To see it live I need SAT with theforeman/foreman_templates#191 I guess? (I haven't found it in the description)

@lhellebr
Copy link
Contributor Author

Yes

@lhellebr lhellebr requested review from a team December 16, 2024 10:11
@lhellebr
Copy link
Contributor Author

This passed in the related Robottelo PR

Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pondrejk pondrejk merged commit 65a1c8e into SatelliteQE:master Jan 6, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants