Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Global Registration OUIA IDs #870

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Update Global Registration OUIA IDs #870

merged 1 commit into from
Jul 2, 2023

Conversation

shweta83
Copy link
Contributor

OUIA IDs of Global Registration are updated and it is causing failures in stream. This change only impacts stream.

@shweta83 shweta83 added the No-CherryPick PR doesnt need CherryPick to previous branches label Jun 27, 2023
@shweta83 shweta83 force-pushed the fix_os_id branch 2 times, most recently from 65dd9a1 to ddc0fe0 Compare June 27, 2023 07:37
@shweta83 shweta83 requested review from a team June 27, 2023 10:40
lhellebr
lhellebr approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes in product permanent and intentional? If yes and if the tests pass, ACK.

sambible
sambible approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending some results showing this working in regular Satellite as well. I will say, this is far superior to the locators we were using previously, assuming these ouia IDs are in the product. Those previous one only worked because nothing else would ever use those same tags above those elements in the page 😕

@shweta83
Copy link
Contributor Author

Are these changes in product permanent and intentional? If yes and if the tests pass, ACK.

Since these changes are only in stream so I cannot say in confidence if it is permanent but this change will help with the PRT running on master and E2E test cases as well.

@shweta83
Copy link
Contributor Author

ACK pending some results showing this working in regular Satellite as well. I will say, this is far superior to the locators we were using previously, assuming these ouia IDs are in the product. Those previous one only worked because nothing else would ever use those same tags above those elements in the page 😕

If you mean regular as 6.14.0 then No, this change currently impacts stream only.

@omkarkhatavkar
Copy link
Collaborator

@shweta83 can you run some tests here using PRT?

@omkarkhatavkar
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k test_positive_global_registration_form

@omkarkhatavkar
Copy link
Collaborator

PRT passed!

@omkarkhatavkar omkarkhatavkar merged commit 98b15ad into SatelliteQE:master Jul 2, 2023
6 checks passed
shweta83 added a commit to shweta83/airgun that referenced this pull request Jul 14, 2023
@shweta83
Update Global Registration OUIA IDs (SatelliteQE#870)
86410e3
shweta83 added a commit to shweta83/airgun that referenced this pull request Jul 19, 2023
@shweta83
Update Global Registration OUIA IDs (SatelliteQE#870)
10a3f87
Gauravtalreja1 pushed a commit that referenced this pull request Jul 20, 2023
@shweta83
Update Global Registration OUIA IDs (#870) (#904)
5dec79a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhellebr lhellebr lhellebr approved these changes

@sambible sambible sambible approved these changes

Assignees

@shweta83 shweta83

Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shweta83 @omkarkhatavkar @lhellebr @sambible