Improve CLI functionality and CLI tests #30
Merged
+227
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synkd
force-pushed
the
improve_cli_functionality_and_tests
branch
3 times, most recently
from
c97cc7b to
3aa142f
Compare
|
Sample output of simple and detailed inventory display (using mocked data): |
JacobCallahan
requested changes
Feb 15, 2024
tests/test_manifester.py
Outdated
| @@ -97,7 +111,7 @@ def post(self, *args, **kwargs): | |||
| self.access_token = "this is a simulated access token" | |||
| return self | |||
| if args[0].endswith("allocations"): | |||
| self.uuid = "1234567890" | |||
| self.uuid = f"{SUB_ALLOCATION_UUID}" | |||
There was a problem hiding this comment.
same string conversion comment
synkd
force-pushed
the
improve_cli_functionality_and_tests
branch
from
3aa142f to
668d3b8
Compare
JacobCallahan
approved these changes
Mar 4, 2024
This PR is another step in the manifester inventory/CLI improvement effort. It adds functionality to and testing for the CLI with the goal of making Manifester useful for interactive users in addition to its current primary usecase in automated workflows. Requires SatelliteQE#29, so starting this in draft status.
This commit adds a 'manifester delete' command and makes various changes to support its implementation. Notably, it adds a `minimal_init` option to Manifester's `__init__` method to allow instantiating Manifester objects with a subset of the attributes required for a full Manifester run. This change does require some modifications to the structure of the settings file, which I will push in a subsequent commit. This commit also uses the `minimal_init` option to add a CLI option to sync the inventory from RHSM, implements some changes suggested in review, and makes several other small tweaks.
synkd
force-pushed
the
improve_cli_functionality_and_tests
branch
from
d095df5 to
d6e6423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another step in the manifester inventory/CLI improvement effort. It adds functionality to and testing for the CLI with the goal of making Manifester useful for interactive users in addition to its current primary usecase in automated workflows.