Isolate manifester's logger #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synkd
approved these changes
Jul 17, 2024
ogajduse
force-pushed
the
fix/use-isolated-logger
branch
from
4eed2b1 to
687800e
Compare
ogajduse
force-pushed
the
fix/use-isolated-logger
branch
from
687800e to
652b432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broker and Manifester both use the default logger, so the last to have their log setup run overrides the other.
This PR isolates the manifester's own logger in its library, but it keeps the possibility to modify the logger from outside using the
setup_logzeroAPI.