Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 6.15.0 #1002

Closed
wants to merge 1 commit into from
Closed

Version 6.15.0 #1002

wants to merge 1 commit into from

Conversation

lpramuk
Copy link
Contributor

@lpramuk lpramuk commented Sep 26, 2023

We lack proper versioning of nailgun module. For all branches we use currently it says just 0.32.0
Lets get used to updating nailgun package version after each branching/release.
It will be more obvious from what branch we installed the nailgun.

Keeping 6.15.0 in master as nigtly version/future version so being compatible with current tagging.

BTW
For multiple nailguns being installed at the same time we need proper versioning.
pip download saves nailgun from different branches to the very same file nailgun-0.32.0.zip. Oops.

@lpramuk lpramuk self-assigned this Sep 26, 2023
@lpramuk lpramuk added No-CherryPick PR doesnt need CherryPick to previous branches Stream labels Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (08c4bb8) 92.15% compared to head (5e0725f) 92.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files           6        6           
  Lines        3047     3047           
=======================================
  Hits         2808     2808           
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jyejare
Copy link
Member

jyejare commented Sep 26, 2023

@lpramuk We have releases auto-created but that is for the master branch only and is being created to understand the changelogs per snap.

This looks like a good idea but we had to update the https://github.com/SatelliteQE/nailgun/blob/master/.github/workflows/merge_to_master.yml to update PyPI package for each separate branch version.

@lpramuk
Copy link
Contributor Author

lpramuk commented Sep 27, 2023

@jyejare
Sure. Module version doesn't go against this or does ?

I just want pip list to produce sane results instead of very meaningless
nailgun 0.32.0
shown for all branches

This looks like a good idea but we had to update the https://github.com/SatelliteQE/nailgun/blob/master/.github/workflows/merge_to_master.yml to update PyPI package for each separate branch version.

I don't want to release it to pypi - we always install nailgun by branches. Good start is to bump module version after each branching. X.Y.0

In future we could bump the version in z digit too if needed and release to pypi. But then it would be conflicting - tagging master with inappropriate 6.14.z tags - lets restrain releasing to pypi for now

@JacobCallahan
Copy link
Member

i'm not opposed to the change in this PR, but I don't think it solves the problem of multiple nailgun versions. it's almost certainly better to replace the currently installed version of nailgun every time with the latest branch using pip git installs directly.
see: SatelliteQE/robottelo#12840

Copy link

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Nov 27, 2023
Copy link

github-actions bot commented Dec 5, 2023

This pull request is now being closed after stale warnings.

@github-actions github-actions bot closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stale Stale issue or Pull Request Stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants