-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump codecov/codecov-action from 1.0.13 to 4.0.1 #1088
Bump codecov/codecov-action from 1.0.13 to 4.0.1 #1088
Conversation
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 1.0.13 to 4.0.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v1.0.13...v4.0.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
5ad065d
to
4957762
Compare
uses: codecov/codecov-action@v4.0.1 | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the failure in GHA checks, and the requirement for codecov action update, I think the token option is now required. Could I ask Nailgun maintainers @JacobCallahan @jyejare @omkarkhatavkar to generate the token and upload it as secret, so we can use it here?
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4.0.1/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/v4.0.1/dist/codecov create-commit -C 4957762a29a5dc93f0609665298c3928aef2dcf6 -Z
==> Uploader SHASUM verified (05b8[30](https://github.com/SatelliteQE/nailgun/actions/runs/7985527688/job/21804148503?pr=1088#step:9:31)6070b7f242adb37232c5cdb624[31](https://github.com/SatelliteQE/nailgun/actions/runs/7985527688/job/21804148503?pr=1088#step:9:32)ba89958d4c08243e5190a803543b2b codecov)
info - 2024-02-21 07:35:40,773 -- ci service found: github-actions
Error: Codecov token not found. Please provide Codecov token with -t flag.
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4.0.1/dist/codecov' failed with exit code 1
uses: codecov/[email protected] | |
with: | |
uses: codecov/[email protected] | |
with: | |
token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead the better option is to get rid of codecov altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #1102
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, we can close this PR as we removed the codecov
A newer version of codecov/codecov-action exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps codecov/codecov-action from 1.0.13 to 4.0.1.
Release notes
Sourced from codecov/codecov-action's releases.
... (truncated)
Changelog
Sourced from codecov/codecov-action's changelog.
... (truncated)
Commits
e0b68c6
fix: show both token uses in readme (#1250)1f9f557
Add all args (#1245)09686fc
Update README.md (#1243)f30e495
fix: update action.yml (#1240)a7b945c
fix: allow for other archs (#1239)98ab2c5
Update package.json (#1238)43235cc
Update README.md (#1237)0cf8684
chore(ci): bump to node20 (#1236)8e1e730
build(deps-dev): bump@typescript-eslint/eslint-plugin
from 6.19.1 to 6.20.0 ...61293af
build(deps-dev): bump@typescript-eslint/parser
from 6.19.1 to 6.20.0 (#1235)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)