Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] adding the PRT result and labels on github comment #1117

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #1089

Details

SatelliteQE/robottelo#13979
SatelliteQE/robottelo#14093

Problem Statement

  1. Currently, the labels PRT-Passed and PRT-Failed are added based on the results of the Pull Request Testing (PRT). However, when contributors update the pull request with new commits, these labels might remain, leading to potential confusion. There is a need to automatically remove these labels when new commits are added to the pull request.
  2. Currently, the PRT result gets clean after a new commit and there is no way for PR to know what happened with the result. PRT passed/failed labels also need to be added automatically this helps in reviewing the PR quickly and merging them

Solution

  1. Add the dispatch workflow that takes care of this thing from the Jenkins CI update the GitHub comment with all details and apply the filter.
  2. To address this issue, we propose implementing a solution using GitHub Actions (GHA). The solution involves periodically checking the GitHub status API to monitor for new commits on the pull request. Upon detecting a new commit, the workflow will automatically remove the PRT-Passed and PRT-Failed labels from the pull request. This ensures that the labels accurately reflect the current status of the pull request, reducing confusion and maintaining clarity for reviewers and contributors.

Test Result

https://github.com/omkarkhatavkar/robottelo/actions/runs/7916581527/job/21610780591?pr=216

@Satellite-QE Satellite-QE added 6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (6.14.z@8ca2de2). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             6.14.z    #1117   +/-   ##
=========================================
  Coverage          ?   92.12%           
=========================================
  Files             ?        6           
  Lines             ?     3048           
  Branches          ?        0           
=========================================
  Hits              ?     2808           
  Misses            ?      240           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravtalreja1 Gauravtalreja1 merged commit 1155eca into 6.14.z Apr 9, 2024
20 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.14.z-5b7e0bdc9e8f4fb96faca03a575bad8ab36827ad branch April 9, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants