-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TablePreferences entity #928
Add TablePreferences entity #928
Conversation
062c07a
to
32d6339
Compare
|
The dependent robottelo PR has been merged. Can we also merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The make docs
failure is related to the change in the table-preferences entity only, please fix it !
Also, update unit tests for the the new class!
Yes, this failure is a real one, I'll fix it. Previously, already the test invocation has been failing. |
32d6339
to
f3cdb65
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 92.18% 92.22% +0.04%
==========================================
Files 6 6
Lines 3031 3050 +19
==========================================
+ Hits 2794 2813 +19
Misses 237 237
☔ View full report in Codecov by Sentry. |
Patch coverage is only 26% , so you should now add unit tests. |
b7947cb
to
d4f7283
Compare
Yes, I was working on it, it just took a little while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for not using PRT? Looks good either way. Also, you aren't alone on forgetting to add tests for Nailgun PRs :)
trigger: test-robottelo |
d4f7283
to
7b85ca2
Compare
Who knows why I still don't see any PRT results. But I think we can merge. The test using this is merged already! |
PRT results get overridden once you add a new commit in the code. |
trigger: test-robottelo |
* Add TablePreferences entity * Tests for TablePreferences entity (cherry picked from commit 33db04b)
* Add TablePreferences entity * Tests for TablePreferences entity (cherry picked from commit 33db04b)
Description of changes
Added TablePreferences entity.
Functional demonstration
Shouldn't cause regression, this test uses search and hasn't changed:
The same happens when I change that test to use ServerConfig explicitly, and don't change anything else (so it doesn't specify the new argument).
This is a new test using it: