Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] fixed the cherry pick GHA #933

Merged

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #930

Description of changes

Describe in detail the changes made, and any potential impacts to callers.

Upstream API documentation, plugin, or feature links

Link to any relevant upstream API documentation that relates to the content of the PR.

Functional demonstration

Provide an execution of the modified code, with ipython code blocks or screen shots.
You can exercise the code as raw API calls or using any other method.

Your contribution should include updates to the unit tests, covering the modified portions or adding new coverage.

Example:

# Demonstrate functional Snapshot read in ipython
In [1]: from nailgun.entities import Snapshot
In [2]: Snapshot(host='sat.instance.addr.com', id='snap_uuid').read()
Out [2]: <read method result>
Additional Information

Any additional notes for reviewers, comments about the change, TODO lists on WIP PRs, etc.

(cherry picked from commit cfed8c9)
@Satellite-QE Satellite-QE added 6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (6.14.z@d425944). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             6.14.z     #933   +/-   ##
=========================================
  Coverage          ?   92.18%           
=========================================
  Files             ?        6           
  Lines             ?     3031           
  Branches          ?        0           
=========================================
  Hits              ?     2794           
  Misses            ?      237           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ogajduse ogajduse merged commit 0b7d8b4 into 6.14.z Jun 23, 2023
@ogajduse ogajduse deleted the cherry-pick-6.14.z-cfed8c9dca63260ca79b60cf58aa72fa49fc368e branch June 23, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants