Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper to delete LCE from capsule #935

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jun 14, 2023

Description of changes

Adds helper to disassociate lifecycle environment from a capsule

Upstream API documentation, plugin, or feature links

/apidoc/v2/capsule_content.en.html

Functional demonstration
$ pytest tests/foreman/api/test_capsulecontent.py::TestCapsuleContentManagement::test_positive_remove_capsule_orphans
=================================================================== test session starts ===================================================================
...
collected 1 item                                                                                                                                          

tests/foreman/api/test_capsulecontent.py .                                                                                                          [100%]

======================================================== 1 passed, 1 warning in 111.38s (0:01:51) =========================================================

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.13.z 6.14.z labels Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (cfed8c9) 92.18% compared to head (f2523c4) 92.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
+ Coverage   92.18%   92.19%   +0.01%     
==========================================
  Files           6        6              
  Lines        3031     3037       +6     
==========================================
+ Hits         2794     2800       +6     
  Misses        237      237              
Impacted Files Coverage Δ
nailgun/entities.py 91.24% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endpoint seems good, but you should at least update the GenericTestCase with the new endpoint

class GenericTestCase(TestCase):

Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@omkarkhatavkar omkarkhatavkar merged commit 162e767 into SatelliteQE:master Jun 20, 2023
github-actions bot pushed a commit that referenced this pull request Jun 20, 2023
github-actions bot pushed a commit that referenced this pull request Jun 20, 2023
Gauravtalreja1 pushed a commit that referenced this pull request Jun 20, 2023
(cherry picked from commit 162e767)

Co-authored-by: vsedmik <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Jun 20, 2023
(cherry picked from commit 162e767)

Co-authored-by: vsedmik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z 6.14.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants