-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper to delete LCE from capsule #935
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #935 +/- ##
==========================================
+ Coverage 92.18% 92.19% +0.01%
==========================================
Files 6 6
Lines 3031 3037 +6
==========================================
+ Hits 2794 2800 +6
Misses 237 237
☔ View full report in Codecov by Sentry. |
37a4ca0
to
2b50cba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Endpoint seems good, but you should at least update the GenericTestCase with the new endpoint
nailgun/tests/test_entities.py
Line 2105 in cfed8c9
class GenericTestCase(TestCase): |
2b50cba
to
f2523c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(cherry picked from commit 162e767)
(cherry picked from commit 162e767)
(cherry picked from commit 162e767) Co-authored-by: vsedmik <[email protected]>
(cherry picked from commit 162e767) Co-authored-by: vsedmik <[email protected]>
Description of changes
Adds helper to disassociate lifecycle environment from a capsule
Upstream API documentation, plugin, or feature links
/apidoc/v2/capsule_content.en.html
Functional demonstration