Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.12.z] Add support for RHCloud Cloud Connector #942

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

mstrlc
Copy link
Contributor

@mstrlc mstrlc commented Jun 21, 2023

Cherrypick of PR: #920

Description of changes

This PR adds Nailgun support for RHCloud Cloud Connector API.

Functional demonstration

This feature is tested with Robottelo test tests/foreman/api/test_rhc.py::test_positive_configure_cloud_connector,
see SatelliteQE/robottelo#11395 PRT run.

# Running in Robottelo tests/foreman/api/test_rhc.py::test_positive_configure_cloud_connector.
result = module_target_sat.api.RHCloud().enable_connector(organization_id=module_rhc_org.id)
print(result)
{'id': 4, 'targeting_id': 4, 'job_category': 'Maintenance Operations', 'task_id': '97612455-60d8-45e4-904f-d7b067b9e74f', 'task_group_id': 16, 'triggering_id': 4, 'description': 'Configure Cloud Connector', 'concurrency_level': None, 'time_span': None, 'execution_timeout_interval': None, 'password': None, 'key_passphrase': None, 'remote_execution_feature_id': 17, 'effective_user_password': None, 'ssh_user': None, 'time_to_pickup': None}
Additional Information

Nailgun tests addded and passing.

* add support for RHCloud Cloud Connector

* remove location_id and organization_id from args

* add Nailgun tests

* add Nailgun tests

* update entity fields

Co-authored-by: Ondřej Gajdušek <[email protected]>

* change the way data are passed to the function

* change the way data are passed to the function

* update test to match change

---------

Co-authored-by: Ondřej Gajdušek <[email protected]>
(cherry picked from commit 13c0375)
@mstrlc mstrlc added the No-CherryPick PR doesnt need CherryPick to previous branches label Jun 21, 2023
@mstrlc mstrlc self-assigned this Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (6.12.z@b323ead). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             6.12.z     #942   +/-   ##
=========================================
  Coverage          ?   93.32%           
=========================================
  Files             ?        6           
  Lines             ?     2952           
  Branches          ?        0           
=========================================
  Hits              ?     2755           
  Misses            ?      197           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ogajduse ogajduse merged commit a0b07e8 into SatelliteQE:6.12.z Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants