Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.13.z] - remove g-chat notification for failed auto-cherrypick, handled in slack #956

Merged

Conversation

omkarkhatavkar
Copy link
Contributor

Description of changes

Describe in detail the changes made, and any potential impacts to callers.

Upstream API documentation, plugin, or feature links

Link to any relevant upstream API documentation that relates to the content of the PR.

Functional demonstration

Provide an execution of the modified code, with ipython code blocks or screen shots.
You can exercise the code as raw API calls or using any other method.

Your contribution should include updates to the unit tests, covering the modified portions or adding new coverage.

Example:

# Demonstrate functional Snapshot read in ipython
In [1]: from nailgun.entities import Snapshot
In [2]: Snapshot(host='sat.instance.addr.com', id='snap_uuid').read()
Out [2]: <read method result>
Additional Information

Any additional notes for reviewers, comments about the change, TODO lists on WIP PRs, etc.

@omkarkhatavkar omkarkhatavkar added the No-CherryPick PR doesnt need CherryPick to previous branches label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (6.13.z@fd48ffe). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             6.13.z     #956   +/-   ##
=========================================
  Coverage          ?   92.06%           
=========================================
  Files             ?        6           
  Lines             ?     3024           
  Branches          ?        0           
=========================================
  Hits              ?     2784           
  Misses            ?      240           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jyejare jyejare merged commit 82c00d0 into SatelliteQE:6.13.z Jul 18, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants