Introduce new project code standards #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
==========================================
- Coverage 92.26% 92.14% -0.12%
==========================================
Files 6 6
Lines 3076 3043 -33
==========================================
- Hits 2838 2804 -34
- Misses 238 239 +1
☔ View full report in Codecov by Sentry. |
JacobCallahan
commented
Jul 26, 2023
| "C", # complexity | ||
| "C4", # flake8-comprehensions | ||
| "COM818", # Trailing comma on bare tuple prohibited | ||
| # "D", # docstrings |
There was a problem hiding this comment.
Docstrings will be enforced in a follow-up PR
JacobCallahan
added
6.11.z
CherryPick
ogajduse
reviewed
Aug 7, 2023
JacobCallahan
force-pushed
the
master
branch
3 times, most recently
from
9b37653
to
cc6f57c
Compare
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks.
ogajduse
approved these changes
Aug 7, 2023
|
@JacobCallahan Would you like to address the Codecov drop in coverage percentage ? |
I would like to know why Codecov claims that the coverage dropped if the PR did not add or remove any functionality. |
jyejare
approved these changes
Aug 10, 2023
This was referenced Aug 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks. (cherry picked from commit 4e4026f)
This was referenced Aug 10, 2023
JacobCallahan
added a commit
to JacobCallahan/nailgun
that referenced
this pull request
Aug 10, 2023
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks.
JacobCallahan
added a commit
to JacobCallahan/nailgun
that referenced
this pull request
Aug 10, 2023
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks.
JacobCallahan
added a commit
to JacobCallahan/nailgun
that referenced
this pull request
Aug 10, 2023
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks.
ogajduse
pushed a commit
that referenced
this pull request
Aug 22, 2023
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks. (cherry picked from commit 4e4026f)
ogajduse
pushed a commit
that referenced
this pull request
Aug 22, 2023
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks.
ogajduse
pushed a commit
that referenced
this pull request
Aug 22, 2023
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks.
ogajduse
pushed a commit
that referenced
this pull request
Aug 22, 2023
This change adds Ruff as the new linter and loosens Black's formatting as well. Due to this change, we can drop flake8 and old pre-commit hooks.
ogajduse
added a commit
to ogajduse/nailgun
that referenced
this pull request
Sep 19, 2023
This reverts commit 4e4026f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds Ruff as the new linter and loosens Black's formatting as well.
Due to this change, we can drop flake8 and old pre-commit hooks.