Changing return value for Discovery create method #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adarsh Dubey <[email protected]>
adarshdubey-star
added
CherryPick
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 6 6
Lines 3076 3076
=======================================
Hits 2838 2838
Misses 238 238
☔ View full report in Codecov by Sentry. |
ogajduse
approved these changes
Aug 6, 2023
rplevka
approved these changes
Aug 7, 2023
omkarkhatavkar
approved these changes
Aug 7, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Adarsh Dubey <[email protected]> (cherry picked from commit f62e367)
This was referenced Aug 7, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Adarsh Dubey <[email protected]> (cherry picked from commit f62e367)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Adarsh Dubey <[email protected]> (cherry picked from commit f62e367)
ogajduse
pushed a commit
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Adarsh Dubey <[email protected]> (cherry picked from commit f62e367)
ogajduse
pushed a commit
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Adarsh Dubey <[email protected]> (cherry picked from commit f62e367)
ogajduse
pushed a commit
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Adarsh Dubey <[email protected]> (cherry picked from commit f62e367)
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was facing
TypeError: DiscoveryRule.__init__() got multiple values for argument 'server_config'as I started using sat object in the test scenarios.