Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Content View Audit Tests #11718

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[6.14.z] Content View Audit Tests #11718

merged 1 commit into from
Jun 28, 2023

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #11433

Leaving this in draft for now, but this will contain a few of the initial tests for the publish audit feature.

Needs this nailgun PR: SatelliteQE/nailgun#922

@sambible @web-flow
Content View Audit Tests (#11433)
2a58db9 
* First test for content-view-audit

* First test for content-view-audit

* add more test cases and a test for composite content views

* Add test for publish_only_if_needed flag

* Remove unnecessary file.

* Finish test for composite content views

* address review comments

* Remove stream markers, change entity to target_sat

(cherry picked from commit e7b264d)
@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jun 21, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_ccv_audit_scenarios tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_check_needs_publish_flag tests/foreman/api/test_contentview.py::TestContentViewRedHatContent::test_cv_audit_scenarios
nailgun: 922

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jun 21, 2023
@Gauravtalreja1
Copy link
Collaborator

@sambible Could you please investigate the PRT failure?

@ogajduse
Copy link
Member

I believe that we should merge SatelliteQE/nailgun#922 first and then re-run PRT using 6.14.z cherry-pick PR of SatelliteQE/nailgun#922.
But SatelliteQE/nailgun#922 explicitly states NoCherryPick, which confuses me. Can you look into it @sambible?

@sambible
Copy link
Contributor

@ogajduse is correct - the sister Nailgun cherrypick needs to be merged before this will pass. Those labels have been updated, it is now properly set to cherrypick to 6.14

@sambible
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_ccv_audit_scenarios tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_check_needs_publish_flag tests/foreman/api/test_contentview.py::TestContentViewRedHatContent::test_cv_audit_scenarios
nailgun: 922

@vsedmik vsedmik merged commit 1b25640 into 6.14.z Jun 28, 2023
21 of 22 checks passed
@vsedmik vsedmik deleted the cherry-pick-6.14.z-e7b264dc6a6c9643cfc807d3ca2f592f0cc8c563 branch June 28, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

Assignees

@sambible sambible

@Satellite-QE Satellite-QE

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Satellite-QE @Gauravtalreja1 @ogajduse @sambible @vsedmik