Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Auto Release WF from non-master branch #12625

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Sep 14, 2023

Removing the WF for Automatic Releases from non-master branches as only master branch commits are considered in Github Releases!

This was been cherrypicked into 6.14.z during the Branching process which should have been removed !

@jyejare jyejare added No-CherryPick PR doesnt need CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 14, 2023
@jyejare jyejare self-assigned this Sep 14, 2023
@jyejare jyejare changed the title Removing Release Dispatch WF from non-master branch Removing Auto Release WF from non-master branch Sep 14, 2023
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I mentioned in SatelliteQE/nailgun#995,

If we have a documentation for branching, adding an extra step to remove the file from the newly branched .z branch would be a good idea.

@jyejare
Copy link
Member Author

jyejare commented Sep 15, 2023

@ogajduse We will soon have auto branching where we will make sure to delete it !

@Gauravtalreja1
Copy link
Collaborator

@jyejare As we need to remove it from all supported .z branches, shouldn't we cherrypick this commit onto those branches?

@jyejare
Copy link
Member Author

jyejare commented Sep 18, 2023

@Gauravtalreja1 It's only in 6.14.z branch now as it's introduced in 6.14.z time only.

@jyejare jyejare merged commit 16c1319 into SatelliteQE:6.14.z Sep 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants