Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16]Podman Push - Podman Push Create and CV tests #14940

Merged
merged 14 commits into from
Aug 5, 2024
Merged

[6.16]Podman Push - Podman Push Create and CV tests #14940

merged 14 commits into from
Aug 5, 2024

Conversation

sambible
Copy link
Contributor

@sambible sambible commented May 3, 2024

First PR for 6.16 Podman work, will eventually encapsulate both pushing and pulling images through Satellite.

Definitely curious for feedback here, as I'm sure there are better ways to be doing what I'm doing currently. Also, curious to know if you all think there should be a new Podman component, and maybe even test file?

@sambible sambible added the Stream Introduced in or relating directly to Satellite Stream/Master label May 3, 2024
@sambible sambible self-assigned this May 3, 2024
@sambible sambible requested a review from a team as a code owner May 3, 2024 04:13
@sambible sambible marked this pull request as draft May 3, 2024 04:13
@sambible sambible added the No-CherryPick PR doesnt need CherryPick to previous branches label May 3, 2024
vsedmik
vsedmik reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like good initials 👍

tests/foreman/cli/test_docker.py Outdated Show resolved Hide resolved
JacobCallahan
JacobCallahan requested changes May 18, 2024
View reviewed changes
tests/foreman/cli/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_docker.py Outdated Show resolved Hide resolved
@sambible sambible changed the title [6.16]Fixture setting up podman work, and skeleton for first test [6.16]Podman Push - Podman Push Create and CV tests Jul 30, 2024
@sambible sambible marked this pull request as ready for review July 30, 2024 19:07
@sambible sambible requested a review from a team as a code owner July 30, 2024 19:07
@sambible
Copy link
Contributor Author

sambible commented Jul 30, 2024 •
edited
Loading

Finished up this PR - has 2 tests that should be passing in stream, and reworked the setup to reflect the final state of the Podman push feature.

Requires: SatelliteQE/nailgun#1209

@sambible sambible mentioned this pull request Jul 30, 2024
Merged
JacobCallahan
JacobCallahan requested changes Jul 30, 2024
View reviewed changes
tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_docker.py::test_podman_push
tests/foreman/api/test_docker.py::test_cv_podman
nailgun: 1209

@vsedmik
Copy link
Contributor

vsedmik commented Jul 31, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_docker.py::TestPodman::test_podman_push tests/foreman/api/test_docker.py::TestPodman::test_cv_podman
nailgun: 1209

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7926
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_docker.py::TestPodman::test_podman_push tests/foreman/api/test_docker.py::TestPodman::test_cv_podman --external-logging
Test Result : ================== 2 passed, 64 warnings in 883.13s (0:14:43) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 31, 2024
vsedmik
vsedmik requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just put a few proposals for change.

tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
tests/foreman/api/test_docker.py Outdated Show resolved Hide resolved
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 31, 2024
vsedmik
vsedmik approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vijaysawant
vijaysawant reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions to merge assert statement wherever possible, otherwise rest of things are fine

@sambible
Copy link
Contributor Author

sambible commented Aug 1, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_docker.py::TestPodman::test_podman_push tests/foreman/api/test_docker.py::TestPodman::test_cv_podman
nailgun: 1209

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7944
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_docker.py::TestPodman::test_podman_push tests/foreman/api/test_docker.py::TestPodman::test_cv_podman --external-logging
Test Result : ================== 2 passed, 65 warnings in 938.53s (0:15:38) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Aug 1, 2024
@JacobCallahan JacobCallahan merged commit 165fea6 into SatelliteQE:master Aug 5, 2024
10 checks passed
@sambible sambible mentioned this pull request Aug 16, 2024
Open
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@sambible @jyejare
[6.16]Podman Push - Podman Push Create and CV tests (SatelliteQE#14940)
540df87 
* Fixture setting up podman work, and skeleton for first test

* Fixture setting up podman work, and skeleton for first test

* Rework podman_push test, finish it, and add test for podman repos with CV

* Fix precommit issues

* Fix docstring issues

* Address review comments

* Docstring

* Rework a few assertions to be smaller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

@ColeHiggins2 ColeHiggins2 Awaiting requested review from ColeHiggins2

@damoore044 damoore044 Awaiting requested review from damoore044

Assignees

@sambible sambible

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sambible @vsedmik @Satellite-QE @JacobCallahan @vijaysawant