Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CC Automation] Update API test to use refresh-all and add CLI test for bulk actions #15451

Merged
merged 8 commits into from
Jun 28, 2024
Merged

[CC Automation] Update API test to use refresh-all and add CLI test for bulk actions #15451

merged 8 commits into from
Jun 28, 2024

Conversation

sambible
Copy link
Contributor

Problem Statement

Adds test coverage for: https://bugzilla.redhat.com/show_bug.cgi?id=2126420 / https://issues.redhat.com/browse/SAT-18199

Related Issues

Also updates robottelo CLI to support hammer alternate-content-source bulk actions, and the API test to cover the endpoint added in SatelliteQE/nailgun#1086

PRT test Cases example
trigger: test-robottelo
pytest: tests/foreman/api/test_acs.py -k 'test_positive_run_bulk_actions'

trigger: test-robottelo
pytest: tests/foreman/cli/test_acs.py -k 'test_bulk_actions'

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 18, 2024
@sambible sambible requested a review from a team June 18, 2024 18:43
@sambible sambible self-assigned this Jun 18, 2024
@sambible sambible requested review from a team as code owners June 18, 2024 18:43
vsedmik
vsedmik requested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise looks good to me 👍
Let's kick on PRT

tests/foreman/api/test_acs.py Outdated Show resolved Hide resolved
jyejare
jyejare approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Framework changes look good

@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_acs.py -k 'test_positive_run_bulk_actions'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7535
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_acs.py -k test_positive_run_bulk_actions --external-logging
Test Result : =========== 1 passed, 6 deselected, 15 warnings in 707.43s (0:11:47) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 26, 2024
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_acs.py -k 'test_bulk_actions'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7541
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_acs.py -k test_bulk_actions --external-logging
Test Result : ========== 1 passed, 13 deselected, 22 warnings in 658.79s (0:10:58) ===========

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 26, 2024
vsedmik
vsedmik requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc strings still need a fix to satisfy CI/CQ.

vsedmik
vsedmik requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the last one missing

robottelo/cli/acs.py Show resolved Hide resolved
@vsedmik
Copy link
Contributor

vsedmik commented Jun 28, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_acs.py -k 'test_bulk_actions'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7569
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_acs.py -k test_bulk_actions --external-logging
Test Result : ========== 1 passed, 13 deselected, 22 warnings in 695.33s (0:11:35) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 28, 2024
vsedmik
vsedmik approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green

@vsedmik vsedmik added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jun 28, 2024
@vsedmik vsedmik merged commit b85cadc into SatelliteQE:master Jun 28, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 28, 2024
@sambible @web-flow
[CC Automation] Update API test to use refresh-all and add CLI test f…
dfcc378 
…or bulk actions (#15451)

* Update API test to use refresh-all and add CLI test for bulk

* Add Verifies docstring section

* Update docstring

Co-authored-by: vsedmik <[email protected]>

* Fix docstrings for api and cli

* Newline to robottelo/cli/acs.py

---------

Co-authored-by: vsedmik <[email protected]>
(cherry picked from commit b85cadc)
@Satellite-QE Satellite-QE mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare approved these changes

@vsedmik vsedmik vsedmik approved these changes

Assignees

@sambible sambible

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sambible @Satellite-QE @vsedmik @jyejare