fix tests from repositories component #16227

vijaysawant · 2024-09-05T15:39:37Z

Problem Statement

[6.16.0] TFA - Compoenent repositories has few tests failing with minor issue, DISTRIBUTOR_CONFLICT , Assertion Error, etc
api/test_product.py::test_positive_filter_product_list
api/test_repositories.py::test_negative_upload_expired_manifest
api/test_repositories.py::test_positive_sync_mulitple_large_repos

Solution

This PR will address those failures

Related Issues

N/A

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_product.py::test_positive_filter_product_list

trigger: test-robottelo
pytest: tests/foreman/api/test_repositories.py::test_negative_upload_expired_manifest

trigger: test-robottelo
pytest: tests/foreman/api/test_repositories.py::test_positive_sync_mulitple_large_repos

vijaysawant · 2024-09-05T15:40:10Z

trigger: test-robottelo
pytest: tests/foreman/api/test_product.py::test_positive_filter_product_list

vijaysawant · 2024-09-06T03:55:48Z

trigger: test-robottelo
pytest: tests/foreman/api/test_product.py::test_positive_filter_product_list

Satellite-QE · 2024-09-06T04:58:09Z

PRT Result

Build Number: 8498
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_product.py::test_positive_filter_product_list --external-logging
Test Result : ================== 1 passed, 9 warnings in 2361.58s (0:39:21) ==================

vijaysawant · 2024-09-07T04:08:43Z

trigger: test-robottelo
pytest: tests/foreman/api/test_repositories.py

Satellite-QE · 2024-09-07T05:37:25Z

PRT Result

Build Number: 8520
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_repositories.py --external-logging
Test Result : ====== 2 failed, 10 passed, 1 skipped, 330 warnings in 4112.81s (1:08:32) ======

vijaysawant · 2024-09-12T15:41:11Z

trigger: test-robottelo
pytest: tests/foreman/api/test_repositories.py

Satellite-QE · 2024-09-12T16:17:03Z

PRT Result

Build Number: 8626
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repositories.py --external-logging
Test Result : =========== 12 passed, 1 skipped, 360 warnings in 1787.15s (0:29:47) ===========

vsedmik · 2024-09-13T07:14:25Z

tests/foreman/api/test_product.py

@@ -209,8 +209,8 @@ def test_positive_filter_product_list(module_sca_manifest_org, module_target_sat
        query={'redhat_only': True, 'per_page': 1000}
    )

-    assert len(custom_products) == 1
-    assert product.name == custom_products[0].name
+    assert len(custom_products) >= 1


Do we know what else is returned by the search on L207 and why? Is it another custom product created by another test within the same org?

when we run whole test module, at L207 we get list of more than one custom products, so at this assertion L212, using greater than one.

Then the assertion doesn't make much sense to me. It just asserts that one of the test in the module (no matter which one) created some custom product.
We can go with function-scoped org and assert == 1 or remove this assertion and rely on the next one.

Okay, removing this assertion, if we use function scoped org then another assertion need to adjust (len of rh_products > 1)

yes agree with @vsedmik , we could scope by function_org and should only have the one created,
or you should able to narrow the search of custom products in module_org, by the name/id/label of the one created just prior?
Do you ~need/expect multiple custom products, or is this just handling when multiple are present?

@damoore044 If we look at L207, custom_product is being search using organization, another test create custom product hence it is giving more than one custom product.
I would remove the assertion and will rely on next one.

tests/foreman/api/test_repositories.py

vijaysawant · 2024-09-13T13:37:27Z

trigger: test-robottelo
pytest: tests/foreman/api/test_product.py::test_positive_filter_product_list

damoore044

Ack nice!
pending prior comments and nonblocking thoughts on the first assertion.

damoore044 · 2024-09-13T13:37:28Z

tests/foreman/api/test_product.py

@@ -209,8 +209,8 @@ def test_positive_filter_product_list(module_sca_manifest_org, module_target_sat
        query={'redhat_only': True, 'per_page': 1000}
    )

-    assert len(custom_products) == 1
-    assert product.name == custom_products[0].name
+    assert len(custom_products) >= 1


yes agree with @vsedmik , we could scope by function_org and should only have the one created,
or you should able to narrow the search of custom products in module_org, by the name/id/label of the one created just prior?
Do you ~need/expect multiple custom products, or is this just handling when multiple are present?

Satellite-QE · 2024-09-13T14:00:14Z

PRT Result

Build Number: 8643
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_product.py::test_positive_filter_product_list --external-logging
Test Result : ================== 1 passed, 9 warnings in 791.08s (0:13:11) ===================

vijaysawant · 2024-09-13T14:33:57Z

trigger: test-robottelo
pytest: tests/foreman/api/test_repositories.py

Satellite-QE · 2024-09-13T15:12:08Z

PRT Result

Build Number: 8646
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repositories.py --external-logging
Test Result : =========== 12 passed, 1 skipped, 348 warnings in 1765.10s (0:29:25) ===========

vijaysawant · 2024-09-13T15:13:53Z

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py

Satellite-QE · 2024-09-13T15:58:10Z

PRT Result

Build Number: 8647
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_repository.py --external-logging
Test Result : ===== 1 failed, 111 passed, 5 skipped, 483 warnings in 2143.88s (0:35:43) ======

vijaysawant · 2024-09-18T11:06:55Z

trigger: test-robottelo
pytest: tests/foreman/api/test_repositories.py

Satellite-QE · 2024-09-18T11:43:04Z

PRT Result

Build Number: 8700
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repositories.py --external-logging
Test Result : ================ 13 passed, 375 warnings in 1920.63s (0:32:00) =================

vsedmik

LGTM. Is the do_not_merge label still valid @vijaysawant ?

(cherry picked from commit 14efc53)

vijaysawant added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z labels Sep 5, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 6, 2024

Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Sep 7, 2024

vijaysawant force-pushed the TFA-repositories-tests branch from 7310f16 to 7975314 Compare September 12, 2024 15:40

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Sep 12, 2024

vijaysawant marked this pull request as ready for review September 13, 2024 02:24

vijaysawant requested a review from a team as a code owner September 13, 2024 02:24

github-actions bot assigned vijaysawant Sep 13, 2024

vijaysawant added the Do Not Merge label Sep 13, 2024

vsedmik reviewed Sep 13, 2024

View reviewed changes

Gauravtalreja1 reviewed Sep 13, 2024

View reviewed changes

tests/foreman/api/test_repositories.py Show resolved Hide resolved

fix tests from repositories component

0d1b21d

vijaysawant force-pushed the TFA-repositories-tests branch from 7975314 to 0d1b21d Compare September 13, 2024 13:36

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 13, 2024

damoore044 approved these changes Sep 13, 2024

View reviewed changes

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 13, 2024

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 13, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 13, 2024

Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Sep 13, 2024

vijaysawant force-pushed the TFA-repositories-tests branch from a9ac75d to 0d1b21d Compare September 18, 2024 10:57

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Sep 18, 2024

vsedmik approved these changes Sep 18, 2024

View reviewed changes

vijaysawant removed the Do Not Merge label Sep 18, 2024

ColeHiggins2 approved these changes Sep 18, 2024

View reviewed changes

vsedmik merged commit 14efc53 into SatelliteQE:master Sep 18, 2024
21 checks passed

github-actions bot pushed a commit that referenced this pull request Sep 18, 2024

fix tests from repositories component (#16227)

f00b9a9

(cherry picked from commit 14efc53)

Satellite-QE mentioned this pull request Sep 18, 2024

[6.16.z] fix tests from repositories component #16404

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix tests from repositories component #16227

fix tests from repositories component #16227

vijaysawant commented Sep 5, 2024 •

edited

Loading

vijaysawant commented Sep 5, 2024 •

edited

Loading

vijaysawant commented Sep 6, 2024

Satellite-QE commented Sep 6, 2024

vijaysawant commented Sep 7, 2024

Satellite-QE commented Sep 7, 2024

vijaysawant commented Sep 12, 2024

Satellite-QE commented Sep 12, 2024

vsedmik Sep 13, 2024

vijaysawant Sep 13, 2024

vsedmik Sep 13, 2024

vijaysawant Sep 13, 2024

damoore044 Sep 13, 2024

vijaysawant Sep 13, 2024

vijaysawant commented Sep 13, 2024

damoore044 left a comment

damoore044 Sep 13, 2024

Satellite-QE commented Sep 13, 2024

vijaysawant commented Sep 13, 2024

Satellite-QE commented Sep 13, 2024

vijaysawant commented Sep 13, 2024

Satellite-QE commented Sep 13, 2024

vijaysawant commented Sep 18, 2024

Satellite-QE commented Sep 18, 2024

vsedmik left a comment

fix tests from repositories component #16227

fix tests from repositories component #16227

Conversation

vijaysawant commented Sep 5, 2024 • edited Loading

Problem Statement

Solution

Related Issues

PRT test Cases example

vijaysawant commented Sep 5, 2024 • edited Loading

vijaysawant commented Sep 6, 2024

Satellite-QE commented Sep 6, 2024

vijaysawant commented Sep 7, 2024

Satellite-QE commented Sep 7, 2024

vijaysawant commented Sep 12, 2024

Satellite-QE commented Sep 12, 2024

vsedmik Sep 13, 2024

Choose a reason for hiding this comment

vijaysawant Sep 13, 2024

Choose a reason for hiding this comment

vsedmik Sep 13, 2024

Choose a reason for hiding this comment

vijaysawant Sep 13, 2024

Choose a reason for hiding this comment

damoore044 Sep 13, 2024

Choose a reason for hiding this comment

vijaysawant Sep 13, 2024

Choose a reason for hiding this comment

vijaysawant commented Sep 13, 2024

damoore044 left a comment

Choose a reason for hiding this comment

damoore044 Sep 13, 2024

Choose a reason for hiding this comment

Satellite-QE commented Sep 13, 2024

vijaysawant commented Sep 13, 2024

Satellite-QE commented Sep 13, 2024

vijaysawant commented Sep 13, 2024

Satellite-QE commented Sep 13, 2024

vijaysawant commented Sep 18, 2024

Satellite-QE commented Sep 18, 2024

vsedmik left a comment

Choose a reason for hiding this comment

vijaysawant commented Sep 5, 2024 •

edited

Loading

vijaysawant commented Sep 5, 2024 •

edited

Loading