Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16.z] Change from module to function fixtures #16346

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[6.16.z] Change from module to function fixtures #16346

merged 1 commit into from
Sep 13, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16345

Problem Statement

I was seeing issues sharing module level fixtures with other tests in the class

Solution

Change the module fixture to function level fixtures, to better work in CI.

Related Issues

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_errata'

@Satellite-QE Satellite-QE added the 6.16.z Introduced in or relating directly to Satellite 6.16 label Sep 12, 2024
@Satellite-QE Satellite-QE requested a review from a team as a code owner September 12, 2024 17:43
@Satellite-QE Satellite-QE added Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 12, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_errata'

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Sep 12, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8630
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_all_hosts_manage_errata --external-logging
Test Result : ========= 4 failed, 73 deselected, 650 warnings in 2508.66s (0:41:48) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Sep 12, 2024
@sambible
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_errata'

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8635
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_all_hosts_manage_errata --external-logging
Test Result : ========= 4 failed, 73 deselected, 2240 warnings in 9340.45s (2:35:40) =========

@sambible
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_errata'

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8636
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_all_hosts_manage_errata --external-logging
Test Result : ========= 4 failed, 73 deselected, 1722 warnings in 8813.94s (2:26:53) =========

@sambible
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_errata'
airgun: 1562

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8637
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_all_hosts_manage_errata --external-logging
Test Result : ========= 4 passed, 73 deselected, 833 warnings in 3507.38s (0:58:27) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Sep 13, 2024
@Satellite-QE Satellite-QE merged commit 145be36 into 6.16.z Sep 13, 2024
19 of 22 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.16.z-8b0e3e033502140f70f258911d21e6076a1b8122 branch September 13, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sambible sambible

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @sambible