Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update subscription_status_label to subscription_facet_attribute #16516

Conversation

yanpliu
Copy link
Contributor

@yanpliu yanpliu commented Sep 27, 2024

Problem Statement

update subscription_status_label to subscription_facet_attribute, as there is no subscription_status_label

Test Cases : PASS

(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/upgrades/test_virtwho.py  -m pre_upgrade --disable-pytest-warnings
============================================================== test session starts ===============================================================
platform linux -- Python 3.11.7, pytest-8.3.2, pluggy-1.5.0
Mandatory Requirements Mismatch: cryptography==43.0.1 broker[docker,podman,hussh]==0.5.7 pytest-reportportal==5.4.2 nailgun @ git+https://github.com/SatelliteQE/nailgun.git@master#egg=nailgun deepdiff==8.0.1 pytest==8.3.3 productmd==1.40 manifester==0.2.8 airgun @ git+https://github.com/SatelliteQE/airgun.git@master#egg=airgun
Optional Requirements Mismatch: sphinx-autoapi==3.3.2 ruff==0.6.7
To update mismatched requirements, run the pytest command with '--update-required-reqs' OR '--update-all-reqs' option.
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/gitrepo/robottelo
configfile: pyproject.toml
plugins: reportportal-5.4.1, order-1.3.0, ibutsu-2.2.4, fixturecollection-0.1.2, cov-5.0.0, services-2.2.1, xdist-3.6.1, mock-3.14.0
collected 2 items / 1 deselected / 1 selected                                                                                                    

tests/upgrades/test_virtwho.py .                                                                                                           [100%]

============================================ 1 passed, 1 deselected, 11 warnings in 99.98s (0:01:39) =============================================
(robottelo_vv_master) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/upgrades/test_virtwho.py  -m post_upgrade --disable-pytest-warnings
============================================================== test session starts ===============================================================
platform linux -- Python 3.11.7, pytest-8.3.2, pluggy-1.5.0
Mandatory Requirements Mismatch: deepdiff==8.0.1 manifester==0.2.8 pytest==8.3.3 pytest-reportportal==5.4.2 productmd==1.40 broker[docker,podman,hussh]==0.5.7 cryptography==43.0.1 airgun @ git+https://github.com/SatelliteQE/airgun.git@master#egg=airgun nailgun @ git+https://github.com/SatelliteQE/nailgun.git@master#egg=nailgun
Optional Requirements Mismatch: ruff==0.6.7 sphinx-autoapi==3.3.2
To update mismatched requirements, run the pytest command with '--update-required-reqs' OR '--update-all-reqs' option.
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/gitrepo/robottelo
configfile: pyproject.toml
plugins: reportportal-5.4.1, order-1.3.0, ibutsu-2.2.4, fixturecollection-0.1.2, cov-5.0.0, services-2.2.1, xdist-3.6.1, mock-3.14.0
collected 2 items / 1 deselected / 1 selected                                                                                                    

tests/upgrades/test_virtwho.py .                                                                                                           [100%]

================================================= 1 passed, 1 deselected, 12 warnings in 59.17s ==================================================

@yanpliu yanpliu requested a review from a team as a code owner September 27, 2024 03:17
@yanpliu yanpliu self-assigned this Sep 27, 2024
@yanpliu yanpliu added 6.16.z Introduced in or relating directly to Satellite 6.16 No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 27, 2024
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did you mean to use CherryPick instead of No-CherryPick label @yanpliu ?

Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanpliu
Copy link
Contributor Author

yanpliu commented Oct 11, 2024

Looks good to me. Did you mean to use CherryPick instead of No-CherryPick label @yanpliu ?

Have already use the "CherryPick", thank you very much for your suggestion

1 similar comment
@yanpliu
Copy link
Contributor Author

yanpliu commented Oct 11, 2024

Looks good to me. Did you mean to use CherryPick instead of No-CherryPick label @yanpliu ?

Have already use the "CherryPick", thank you very much for your suggestion

@yanpliu yanpliu added CherryPick PR needs CherryPick to previous branches and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 11, 2024
@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Oct 12, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 5e1b40e into SatelliteQE:master Oct 12, 2024
10 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 12, 2024
Gauravtalreja1 pushed a commit that referenced this pull request Oct 12, 2024
…bute (#16658)

update subscription_status_label to subscription_facet_attribute (#16516)

(cherry picked from commit 5e1b40e)

Co-authored-by: yanpliu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants