Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for ansible-tower/AAP integration with Satellite #16555

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add tests for ansible-tower/AAP integration with Satellite #16555

merged 1 commit into from
Nov 13, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

Missing test coverage for ansible-tower/AAP integration with Satellite

Solution

Add tests for ansible-tower/AAP integration with Satellite

Related Issues

@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 3, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Oct 3, 2024
@Gauravtalreja1 Gauravtalreja1 requested review from a team as code owners October 3, 2024 08:08
@Gauravtalreja1 Gauravtalreja1 marked this pull request as draft October 3, 2024 08:08
@Gauravtalreja1 Gauravtalreja1 marked this pull request as ready for review October 4, 2024 19:50
@Gauravtalreja1 Gauravtalreja1 force-pushed the ansible-tower-intergration branch 3 times, most recently from 8158669 to 41af678 Compare October 8, 2024 10:23
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_dynamic_inventory

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8904
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_dynamic_inventory --external-logging
Test Result : ================= 2 passed, 49 warnings in 1038.89s (0:17:18) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 8, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 9, 2024
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback
provisioning: true

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8921
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback --external-logging --include-onprem-provisioning
Test Result : ================= 2 failed, 111 warnings in 5631.17s (1:33:51) =================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 9, 2024
rplevka
rplevka reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@rplevka rplevka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool and i am excited to see the scenario with the on-premise provisioning. I think we could clean this up a bit by moving the most of the stuff to the fixtures so only the bits relevant to the test scenarios remain, but overall, I really like how well readable this is. Great job!

oh and btw, let's get rid of those static timeouts, unless there is a good reason for not using wait-for. Would that make sense?

tests/foreman/cli/test_ansible.py Show resolved Hide resolved
tests/foreman/cli/test_ansible.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_ansible.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_ansible.py Outdated Show resolved Hide resolved
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8935
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback --external-logging --include-onprem-provisioning
Test Result : ================= 2 failed, 149 warnings in 5799.29s (1:36:39) =================

@Gauravtalreja1 Gauravtalreja1 force-pushed the ansible-tower-intergration branch 2 times, most recently from 0ff78c1 to c631c69 Compare October 21, 2024 16:34
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Oct 21, 2024
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_dynamic_inventory

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9062
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_dynamic_inventory --external-logging
Test Result : ================= 2 failed, 75 warnings in 1448.98s (0:24:08) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 23, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Oct 24, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Oct 24, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Oct 24, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Oct 24, 2024
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback[rhel9-ipv4-uefi]
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Oct 24, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Oct 24, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Oct 24, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Oct 24, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9160
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback[rhel9-ipv4-uefi] --external-logging --include-onprem-provisioning
Test Result : ================= 1 failed, 17 warnings in 2269.45s (0:37:49) ==================

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback[rhel9-ipv4-uefi]
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh
     ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
     ROBOTTELO_server__deploy_arguments__deploy_snap_version: '9.0'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9161
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback[rhel9-ipv4-uefi] --external-logging --include-onprem-provisioning
Test Result : ================= 1 failed, 17 warnings in 2916.85s (0:48:36) ==================

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback[rhel9-ipv4-uefi]
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh
     ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
     ROBOTTELO_server__deploy_arguments__deploy_snap_version: '9.0'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9167
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback[rhel9-ipv4-uefi] --external-logging --include-onprem-provisioning
Test Result : ================= 1 failed, 17 warnings in 2906.97s (0:48:26) ==================

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh
     ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
     ROBOTTELO_server__deploy_arguments__deploy_snap_version: '9.0'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9342
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_ansible.py::TestAnsibleAAPIntegration::test_positive_ansible_provisioning_callback --external-logging --include-onprem-provisioning
Test Result : ================= 1 passed, 17 warnings in 2437.09s (0:40:37) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Nov 12, 2024
@shubhamsg199 shubhamsg199 merged commit c060290 into SatelliteQE:master Nov 13, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
@Gauravtalreja1 @web-flow
Add tests for ansible-tower/AAP integration with Satellite (#16555)
482260c 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c060290)
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
@Gauravtalreja1 @web-flow
Add tests for ansible-tower/AAP integration with Satellite (#16555)
9061f4a 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c060290)
This was referenced Nov 13, 2024
Open
Open
@Gauravtalreja1 Gauravtalreja1 deleted the ansible-tower-intergration branch November 13, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@rplevka rplevka rplevka approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @Satellite-QE @rplevka @shubhamsg199