Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] - changes to use the beaker urls for running upstream sanity (#16549) #16623

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

omkarkhatavkar
Copy link

Problem Statement

Currently, the sanity tests are tightly coupled with "Oh Snap" for retrieving required repository URLs. This creates a dependency that hinders the flexibility of running the same tests with alternative URL sources, such as Beaker URLs. The reliance on "Oh Snap" is particularly limiting when running upstream sanity tests right after building the necessary bits. This dependency affects the ability to run tests in different environments efficiently.

Solution

This PR aims to decouple the sanity tests from "Oh Snap" by introducing a more flexible approach for handling repository URLs. Instead of relying exclusively on "Oh Snap" to fetch the URLs, we will modify the behaviour to allow passing the repository URLs directly through a repos file. This approach provides more control and adaptability, enabling tests to run seamlessly with either Beaker URLs or other sources without modifying the core logic.

By doing this, we improve the modularity of the tests, allowing upstream sanity runs to proceed immediately after building the necessary bits, enhancing efficiency and reducing dependencies on external services.

CI PR Dependancy

1504

Test Result

============================= test session starts ==============================
collecting ... collected 5450 items / 5439 deselected / 11 selected

tests/foreman/installer/test_installer.py::test_satellite_installation 
tests/foreman/api/test_computeresource_gce.py::TestGCEHostProvisioningTestCase::test_positive_gce_host_provisioned[sat] 
tests/foreman/api/test_organization.py::TestOrganization::test_positive_create_with_name_and_description[alphanumeric] 
tests/foreman/api/test_repository.py::TestRepositorySync::test_positive_sync_rh 
tests/foreman/api/test_user.py::TestUserRole::test_positive_create_with_role[1] 
tests/foreman/endtoend/test_api_endtoend.py::TestEndToEnd::test_positive_find_admin_user 
tests/foreman/installer/test_installer.py::test_capsule_installation

======= 12 passed, 5439 deselected, 5681 warnings in 3269.71s (0:54:29) ========

@omkarkhatavkar omkarkhatavkar requested review from a team as code owners October 9, 2024 12:00
@omkarkhatavkar omkarkhatavkar changed the title changes to use the beaker urls for running upstream sanity (#16549) [cherrypick] [6.15.z] - changes to use the beaker urls for running upstream sanity (#16549) Oct 9, 2024
@omkarkhatavkar omkarkhatavkar added No-CherryPick PR doesnt need CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Oct 9, 2024
@omkarkhatavkar omkarkhatavkar changed the title [cherrypick] [6.15.z] - changes to use the beaker urls for running upstream sanity (#16549) [6.15.z] - changes to use the beaker urls for running upstream sanity (#16549) Oct 9, 2024
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo

@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pytest: -m 'build_sanity and not no_compose' tests/foreman
env:
ROBOTTELO_server__version__source: 'nightly'
ROBOTTELO_capsule__version__source: 'nightly'

@omkarkhatavkar
Copy link
Author

trigger: test-robottelo

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8944
Build Status: SUCCESS
PRT Comment: pytest /opt/app-root/src/robottelo/tests/foreman -v -m build_sanity --external-logging
Test Result : ======= 12 passed, 5458 deselected, 5787 warnings in 3061.64s (0:51:01) ========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 10, 2024
@omkarkhatavkar omkarkhatavkar added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Oct 10, 2024
@ogajduse ogajduse merged commit 133996d into SatelliteQE:6.15.z Oct 11, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants