Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network type option for Host checkout #16639

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add network type option for Host checkout #16639

merged 1 commit into from
Oct 11, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Oct 10, 2024 •
edited
Loading

Problem Statement

Host checkout failing for IPv6 because we are missing parameter "deploy_network_type" while checking out host.

Solution

Added parameter "deploy_network_type" while host checkout.

Related Issues

@shweta83 shweta83 requested a review from a team as a code owner October 10, 2024 12:34
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_leapp_upgrade_rhel
network_type: ipv6

@shweta83 shweta83 changed the title Debug IPv6 Host checkout failure for leapp [DO NOT MERGE]Debug IPv6 Host checkout failure for leapp Oct 10, 2024
@shweta83 shweta83 changed the title [DO NOT MERGE]Debug IPv6 Host checkout failure for leapp [Test PR]Debug IPv6 Host checkout failure for leapp Oct 10, 2024
@ogajduse
Copy link
Member

converting to draft as the subject of the PR states [Test PR].

@ogajduse ogajduse marked this pull request as draft October 10, 2024 13:07
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8945
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py -k test_positive_leapp_upgrade_rhel --external-logging
Test Result : ================= 2 passed, 204 warnings in 5087.70s (1:24:47) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 10, 2024
@shweta83 shweta83 force-pushed the leapp_ipv6_host_checkout_issue branch from cfb74b1 to 378fd9c Compare October 11, 2024 06:20
@shweta83 shweta83 changed the title [Test PR]Debug IPv6 Host checkout failure for leapp Add network type for IPv6 Host checkout Oct 11, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 11, 2024
@shweta83 shweta83 changed the title Add network type for IPv6 Host checkout Add network type option for Host checkout Oct 11, 2024
@shweta83 shweta83 marked this pull request as ready for review October 11, 2024 06:22
@shweta83 shweta83 requested a review from a team as a code owner October 11, 2024 06:22
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py tests/foreman/ui/test_errata.py -k 'test_positive_leapp_upgrade_rhel or test_positive_apply_for_all_hosts'

@shweta83 shweta83 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master TestFailure Issues and PRs related to a test failing in automation labels Oct 11, 2024
@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 11, 2024
@shweta83
Copy link
Contributor Author

The failure is not related to the change in this PR.

@shweta83 shweta83 added the Easy Fix :) Easiest Fix to review and quick merge request. label Oct 11, 2024
shubhamsg199
shubhamsg199 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shweta83 shweta83 force-pushed the leapp_ipv6_host_checkout_issue branch from 378fd9c to 81b561d Compare October 11, 2024 10:53
@shubhamsg199 shubhamsg199 merged commit 6eb87cc into SatelliteQE:master Oct 11, 2024
8 checks passed
@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 11, 2024
@shweta83 shweta83 added 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Oct 11, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py -k test_positive_leapp_upgrade_rhel

@shweta83 shweta83 removed the Easy Fix :) Easiest Fix to review and quick merge request. label Oct 16, 2024
github-actions bot pushed a commit that referenced this pull request Oct 16, 2024
@shweta83 @web-flow
Add network type option for Host checkout (#16639)
c4fad83 
Add network type option for Host checkout

(cherry picked from commit 6eb87cc)
@Satellite-QE Satellite-QE mentioned this pull request Oct 16, 2024
Merged
@Gauravtalreja1 Gauravtalreja1 added No-CherryPick PR doesnt need CherryPick to previous branches and removed 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Oct 16, 2024
github-actions bot pushed a commit that referenced this pull request Oct 16, 2024
@shweta83 @web-flow
Add network type option for Host checkout (#16639)
4593736 
Add network type option for Host checkout

(cherry picked from commit 6eb87cc)
@Satellite-QE Satellite-QE mentioned this pull request Oct 16, 2024
Open
Gauravtalreja1 pushed a commit that referenced this pull request Oct 16, 2024
@Satellite-QE @shweta83
[6.16.z] Add network type option for Host checkout (#16681)
0e35241 
Add network type option for Host checkout  (#16639)

Add network type option for Host checkout

(cherry picked from commit 6eb87cc)

Co-authored-by: Shweta Singh <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shweta83 @jyejare
Add network type option for Host checkout (SatelliteQE#16639)
40be468 
Add network type option for Host checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@amolpati30 amolpati30 amolpati30 approved these changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@shweta83 shweta83

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream Introduced in or relating directly to Satellite Stream/Master TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shweta83 @ogajduse @Satellite-QE @Gauravtalreja1 @shubhamsg199 @amolpati30