-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for host with .ics domain name #16679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambible
added
CherryPick
PR needs CherryPick to previous branches
AutoMerge_Cherry_Picked
The cherrypicked PRs of master PR would be automerged if all checks passing
6.16.z
Introduced in or relating directly to Satellite 6.16
labels
Oct 15, 2024
trigger: test-robottelo |
Satellite-QE
added
the
PRT-Passed
Indicates that latest PRT run is passed for the PR
label
Oct 15, 2024
damoore044
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good pending @ColeHiggins2 's comment
vijaysawant
requested changes
Oct 15, 2024
Satellite-QE
removed
the
PRT-Passed
Indicates that latest PRT run is passed for the PR
label
Oct 15, 2024
ColeHiggins2
approved these changes
Oct 15, 2024
Merge pending @vijaysawant Comments |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Add test for host with .ics domain name * address comments and update docstring (cherry picked from commit 295d292)
trigger: test-robottelo |
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
* Add test for host with .ics domain name * address comments and update docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.16.z
Introduced in or relating directly to Satellite 6.16
AutoMerge_Cherry_Picked
The cherrypicked PRs of master PR would be automerged if all checks passing
CherryPick
PR needs CherryPick to previous branches
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
This is testing a case where hosts assigned a domain ending in .ics cause Satellite to error out on old and new UI when navigating to the details page.
Related Issues
https://issues.redhat.com/browse/SAT-26202
PRT
trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_read_host_with_ics_domain'