Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for host with .ics domain name #16679

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

sambible
Copy link
Contributor

Problem Statement

This is testing a case where hosts assigned a domain ending in .ics cause Satellite to error out on old and new UI when navigating to the details page.

Related Issues

https://issues.redhat.com/browse/SAT-26202

PRT

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_read_host_with_ics_domain'

@sambible sambible added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 15, 2024
@sambible sambible requested a review from a team October 15, 2024 14:51
@sambible sambible self-assigned this Oct 15, 2024
@sambible sambible requested a review from a team as a code owner October 15, 2024 14:51
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_read_host_with_ics_domain'

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 15, 2024
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good pending @ColeHiggins2 's comment

tests/foreman/ui/test_host.py Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 15, 2024
@ColeHiggins2
Copy link
Member

Merge pending @vijaysawant Comments

@ColeHiggins2 ColeHiggins2 merged commit 295d292 into SatelliteQE:master Oct 15, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
* Add test for host with .ics domain name

* address comments and update docstring

(cherry picked from commit 295d292)
Copy link

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_read_host_with_ics_domain'

jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
* Add test for host with .ics domain name

* address comments and update docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants