use packaged pytest, not some venv #16694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameerpathan111
added
No-CherryPick
|
trigger: test-robottelo |
|
@jameerpathan111 given the executed |
|
PRT Result |
Satellite-QE
added
the
PRT-Failed
|
The PRT failure is expected, you need to run it against an AAP that has my deployment patches in. |
jameerpathan111
added
6.14.z
jameerpathan111
approved these changes
Oct 18, 2024
|
@evgeni Acked. Can you fix pre-commit failures? |
evgeni
force-pushed
the
fam-packaged-pytest
branch
from
8118b5e
to
50c0935
Compare
|
Done! |
jameerpathan111
added
CherryPick
ekohl
reviewed
Oct 18, 2024
| @@ -74,6 +74,13 @@ def setup_fam(module_target_sat, module_sca_manifest, install_import_ansible_rol | |||
| # Edit Makefile to not try to rebuild the collection when tests run | |||
| module_target_sat.execute(f"sed -i '/^live/ s/$(MANIFEST)//' {FAM_ROOT_DIR}/Makefile") | |||
There was a problem hiding this comment.
Not a blocker, but could we introduce an environment variable for this as well so we can avoid patching code altogether?
There was a problem hiding this comment.
Maybe, probably. But not today ;)
evgeni
force-pushed
the
fam-packaged-pytest
branch
from
50c0935
to
d08f66e
Compare
|
Rebased and updated to match the last version of theforeman/foreman-ansible-modules#1788 -- now only replacing |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
(cherry picked from commit ddb3ec1)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
(cherry picked from commit ddb3ec1)
This was referenced Oct 21, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
(cherry picked from commit ddb3ec1)
jameerpathan111
pushed a commit
that referenced
this pull request
Oct 21, 2024
use packaged pytest, not some venv (#16694) (cherry picked from commit ddb3ec1) Co-authored-by: Evgeni Golov <[email protected]>
jameerpathan111
pushed a commit
that referenced
this pull request
Oct 21, 2024
use packaged pytest, not some venv (#16694) (cherry picked from commit ddb3ec1) Co-authored-by: Evgeni Golov <[email protected]>
jameerpathan111
pushed a commit
that referenced
this pull request
Oct 21, 2024
use packaged pytest, not some venv (#16694) (cherry picked from commit ddb3ec1) Co-authored-by: Evgeni Golov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
The current FAM test setup relies on being able to reach the Internet, which is "bad design"™ but also actually broken in IPv6-only environments because our lab network has IPv6, but no route to the broader Internet.
Solution
Instead of installing test dependencies via
pipfrom the Internet, install them viadnffrom the RH CDN and use them in the tests here.There is an accompanying PR against the repo that carries the setup playbooks.
Related Issues