-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to check Satellite documention links for GA'ed Satellite #16812
Conversation
Tested the code locally with Satellite 6.15 and found 3 broken links. Filed SAT-29022 and SAT-28994. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK with small nitpick 😉
e76d43f
to
c78f80c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, minor comment
'jobinvocation', | ||
'audit', | ||
'factvalue', | ||
'dashboard', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slightly concerned about keeping this list up to date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't think of better approach atm:/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. But agree with previous comments... It will be hard to maintain the list of pages. Ideas how to improve that are welcome.
What about AutoMergeCherrypicked label?
I'm not sure if auto merge works on PR's without PRT comment. We can try though. |
…llite (#16825) Add test to check Satellite documention links for GA'ed Satellite (#16812) (cherry picked from commit 24dce9f) Co-authored-by: Jameer Pathan <[email protected]>
Problem Statement
Historically, after a Satellite release, we have found that the documentation links on Satellite pages were broken, causing bugs and customer cases to be filed, resulting in a poor user experience.
Solution
Related Issues