Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Add conditioning for pool attach #16824

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[6.14.z] Add conditioning for pool attach #16824

merged 2 commits into from
Nov 5, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Oct 31, 2024

Manual cherry-pick of #16575

Fixes #16811

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 labels Oct 31, 2024
@vsedmik vsedmik self-assigned this Oct 31, 2024
@vsedmik vsedmik linked an issue Oct 31, 2024 that may be closed by this pull request
[Failed-AutoCherryPick] - Add conditioning for pool attach #16811
Open
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k dummie

@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 5, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_container_management.py -k test_positive_container_admin_end_to_end_pull

@vsedmik vsedmik force-pushed the 6.14.z-conditionate-pool-attach branch from 1ab20b4 to 14f1684 Compare November 5, 2024 15:45
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 5, 2024

PRT failed with unrelated

17:01:02  dynaconf.validator.ValidationError: ipa.group_users is required in env main

@lhellebr might be interested since it is related to his #16536 which hasn't been CPed to 6.14.z (and Jeknins MR#1501)

@vsedmik vsedmik force-pushed the 6.14.z-conditionate-pool-attach branch from 14f1684 to aae46b5 Compare November 5, 2024 17:03
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9275
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_container_management.py -k test_positive_container_admin_end_to_end_pull --external-logging
Test Result : ========== 1 passed, 3 deselected, 16 warnings in 1084.08s (0:18:04) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 5, 2024
@vsedmik vsedmik merged commit 273de3d into SatelliteQE:6.14.z Nov 5, 2024
10 checks passed
@vsedmik vsedmik deleted the 6.14.z-conditionate-pool-attach branch November 6, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed-AutoCherryPick] - Add conditioning for pool attach
4 participants
@vsedmik @Gauravtalreja1 @Satellite-QE @pondrejk