Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.16.z] removing cloned_from_id key from template object #16844

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16813

Problem Statement

The value of cloned_from_id differs between the two instances, while the rest of the data matches. Since dupe_json is cloned from template, it inherits the id from template, whereas the template object itself was created directly and does not have a clone id . And it causes an assertion error. I remove cloned_from_id to prevent the assertion from failing.

Solution

I remove cloned_from_id key to prevent the assertion from failing and removing cloned_from_id does not impact the test.

removing cloned_from_id key from template

(cherry picked from commit de22c82)
@Satellite-QE Satellite-QE requested a review from a team as a code owner November 4, 2024 11:01
@Satellite-QE Satellite-QE added 6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 4, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_end_to_end_crud

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Nov 4, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9204
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_end_to_end_crud --external-logging
Test Result : ================== 1 passed, 9 warnings in 537.45s (0:08:57) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 4, 2024
@Satellite-QE Satellite-QE merged commit 30f07af into 6.16.z Nov 4, 2024
17 of 18 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.16.z-de22c8218887e297553d6df5a4c10b9302ab7328 branch November 4, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants