Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Test LCE and CV assignment of newly created AK #16880

Merged
merged 3 commits into from
Nov 12, 2024
Merged

[UI] Test LCE and CV assignment of newly created AK #16880

merged 3 commits into from
Nov 12, 2024

Conversation

LadislavVasina1
Copy link
Contributor

Problem Statement

SAT-28981 introduced a bug when creating a new AK which had Library and Default Content view assigned during its creation, it did not have it assigned after its creation.

Solution

Adding UI automation for this bug that tests that LCE and CV assignment went through.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_activationkey.py -k 'test_positive_new_ak_lce_cv_assignment'
Katello:
    katello: 11191

@LadislavVasina1 LadislavVasina1 added UI Issues and PRs involving the UI CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 7, 2024
@LadislavVasina1 LadislavVasina1 self-assigned this Nov 7, 2024
@LadislavVasina1 LadislavVasina1 requested a review from a team as a code owner November 7, 2024 10:51
@LadislavVasina1
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_activationkey.py -k 'test_positive_new_ak_lce_cv_assignment'
Katello:
    katello: 11191

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9301
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_activationkey.py -k test_positive_new_ak_lce_cv_assignment --external-logging
Test Result : ========== 1 passed, 60 deselected, 72 warnings in 1383.54s (0:23:03) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 7, 2024
Gauravtalreja1
Gauravtalreja1 reviewed Nov 11, 2024
View reviewed changes
tests/foreman/ui/test_activationkey.py
Comment on lines +1128 to +1130
session.activationkey.create(
{'name': ak_name, 'lce': {'Library': True}, 'content_view': constants.DEFAULT_CV}
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to test if non-default lifecycle and CV's are selected while AK creation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gauravtalreja1 Can you elaborate on that? Also, I am following the bug description.

@LadislavVasina1 LadislavVasina1 requested a review from a team November 11, 2024 07:45
rmynar
rmynar approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@rmynar rmynar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be easily expanded to test also non-default org/loc/... But it covers the specified bug reproducer. ACK.

@vsedmik vsedmik merged commit 37a277b into SatelliteQE:master Nov 12, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
@LadislavVasina1 @web-flow
[UI] Test LCE and CV assignment of newly created AK (#16880)
8305a04 
* Test lce and cv assignment of new AK

* Remove unused module_lce_library

* docstring change

(cherry picked from commit 37a277b)
@Satellite-QE Satellite-QE mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@rmynar rmynar rmynar approved these changes

@vsedmik vsedmik vsedmik approved these changes

Assignees

@LadislavVasina1 LadislavVasina1

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LadislavVasina1 @Satellite-QE @Gauravtalreja1 @vsedmik @rmynar