-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata for realm CLI tests #7051
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7051 +/- ##
=======================================
Coverage 69.35% 69.35%
=======================================
Files 29 29
Lines 3515 3515
=======================================
Hits 2438 2438
Misses 1077 1077 Continue to review full report at Codecov.
|
Hello @san7ket , I was reading SatelliteQE/satellite6-upgrade#127, trying to come up with a summary of what this test requires. In the test doc string it says: I would like to update that text with more useful info. I will try grep the repo as the links in issue 127 no longer land on the lines you added. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes so far look good to me.
@swadeley What you can do, is clone automation-tools repo to your machine and see state of repository at the time when comment was written:
git clone https://github.com/SatelliteQE/automation-tools.git
cd automation-tools
git log --before 29-11-2017 # gives you log of changes from time before this comment was written
# Newest commit at the time, from November 20, had id of 6945c8ef50d0ede1f0514be7e714c2c3e2b7d2be
git checkout 6945c8ef50d0ede1f0514be7e714c2c3e2b7d2be # get local repository to state when comment was written
Line 1409 was enroll_idm
function, line 1555 was configure_realm
function.
Hope that helps
Thank very much @Mirzal. Detached head state, that brings back memories. I have made an update to the text. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you all |
Changed some tiers to tier2 to make distinction between critical and non-critical parts of the component. Fixed up some text.