Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tides for TORREYPINES and TRUCVERT #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yongjingmao
Copy link
Collaborator

Update the tide data with correct coordinate inputs.

@kvos
Copy link
Member

kvos commented Nov 23, 2023

thanks @yongjingmao, it looks like a major issue as the new tide time-series are completely different. I will rerun the analysis for these two sites, could you also commit the uploaded tides script? thanks

@yongjingmao
Copy link
Collaborator Author

Add script for tide computation

@kvos
Copy link
Member

kvos commented Jan 5, 2024

hi @yongjingmao , sorry I only had time to look at this now. Thanks for the updated tides, I was trying to run the notebook again but the new tides are only until 2013, could you please upload the files with the tides until 1st Jan 2025? Thanks

@yongjingmao
Copy link
Collaborator Author

yongjingmao commented Jan 5, 2024 via email

@kvos
Copy link
Member

kvos commented Jan 5, 2024

thanks, can you please also send me the link tp the updated TORREYPINES tides?

@yongjingmao
Copy link
Collaborator Author

yongjingmao commented Jan 5, 2024 via email

@kvos
Copy link
Member

kvos commented Jan 10, 2024

thanks @yongjingmao , it was a good catch. I re-ran the analysis with the new tides and for TORREYPINEs and TRUCVERT for the 3 algorithms that are tidally-corrected (CoastSat, SHOREX and CASSIE) it does make a difference. See plots below:

Figure in the paper:
3_R2_selected

Revised figure with new tides:
3_R2_selected

While it doesn't change much at Truc Vert, the SDS time-series are much improved at Torrey Pines.
I will contact the journal to see if this can be updated somehow, I don't think it changes the conclusions of the paper in any way but it would be better to have the most accurate figure possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants