Updated Error Handling. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the S5Error and ErrorKind enum. These explicit error types are not required and errors should wrap the internal error fully to not loose details. error module moved to crate level. This puts the error docs in the crate level documentation.
use the new error structure accross module. After this commit there should not be any dangling unwrap left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
This is a big refactoring PR so would take some review effort.
Salient points:
error.rsmove tosrc/. This allows error enum to be documented at crate level (good practise).Simplifying error handling also implies code verbosity. This PR removes more lines than it adds.