-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native-tls
for better close_notify
handling
#41
Use native-tls
for better close_notify
handling
#41
Conversation
Hey @ok300 Thanks for the PR! You will need to setup PGP signing for your commits. Didn't catch it on your last few PR's. You can check out the docs here: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits Also the rust-fmt test is complaining :( |
704abee
to
0763847
Compare
Done, signed the commits and ran |
Awesome! There is a huge PR that I have to review first and get merged which came in before this. This PR will create a merge conflict with that one. I'll have to hold off on merging this. Once that is merged, we will get back to this. For now, you can carry on using your fork in your project so you aren't blocked. |
Hey, the other PR has been merged. You can sync and commit your changes. |
you potentially saved me hours of debugging with this PR! we just faced this issue on android in an upstream project that uses boltz-dart. I've updated boltz.rs & boltzv2.rs to use native-tls for POST calls. Thank you! Please share a Liquid address so I can tip you :) |
Awesome, I'll rebase soon and update this PR! Maybe you can use my LN address [email protected] , much appreciated 🙏 |
I see the relevant changes are already in I'll just close it, to keep things simple. |
Pheonix says |
This PR enables the
native-tls
feature ofureq
as described here: https://docs.rs/ureq/latest/ureq/#https--tls--sslThis brings better handling of TLS
close_notify
alerts. Before this change, the defaultureq
setup caused some POST calls (like/swapstatus
) to fail.Fixes #39