fix: invalid unit comparison in lnurl
tests
#77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boltz-rust/src/util/lnurl.rs
Line 139 in 348a881
Here we were converting the amount from
milli_satoshi
tosatoshi
, butmax_withdrawable
returns us amount insatoshi
. So it was fundamentally a wrong comparison.boltz-rust/src/util/lnurl.rs
Line 147 in 348a881
nit: Also includes minor change in error message.