Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amounts from u32 to u64 in create requests #79

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Oct 25, 2024

Some amount fields in swap create requests were u32, while other relevant fields (fees, min/max in pair limits) were u64.

This meant conversion or typecasting was often necessary when interacting between the two.

To simplify this in callers, this PR updates the u32 amount fields in Swap Create requests to u64.

@i5hi i5hi merged commit e431a04 into SatoshiPortal:trunk Oct 28, 2024
4 checks passed
@i5hi
Copy link
Collaborator

i5hi commented Oct 28, 2024

Thanks @ok300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants