This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Moved rest of sa_insights iteration into try block
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_sa_insights` function had the core logic split between the `try` block and the function code itself. If the `try` was successful, then the rest of the function operated as expected. When the `except` was encountered, it would move to the function code and fail because the `sa_insights` reference doesn't exist in any scope. The rest of the function logic was moved into the `try` block. Additionally, a default `except` was added that will print the exception encountered to stdout. The function continuing to iterate through the list of projects was preserved in this patch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8
The
get_sa_insightsfunction had the core logic split betweenthe
tryblock and the function code itself. If thetrywassuccessful, then the rest of the function operated as expected.
When the
exceptwas encountered, it would move to the functioncode and fail because the
sa_insightsreference doesn't existin any scope.
The rest of the function logic was moved into the
tryblock.Additionally, a default
exceptwas added that will print theexception encountered to stdout.
The function continuing to iterate through the list of projects
was preserved in this patch.