test(sync): restore failing tests #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
commented
Feb 27, 2023
| @@ -34,6 +35,23 @@ func TestFsSyncer_Sync(t *testing.T) { | |||
| "it should copy a directory": { | |||
| fixtureSrc: "src/dir", | |||
| }, | |||
| "it should copy a hard link": { | |||
There was a problem hiding this comment.
In this test we want to test that the files a and b are hard links. But this test seems impossible to do on the CI as hard links are not supported in Git: https://stackoverflow.com/a/3731139/1351436
Comment on lines
+64
to
+73
| "it should replace a file with the same content but not the same mtime": { | ||
| fixtureSrc: "src/file", | ||
| fixtureDst: "dst/cp-file", | ||
| expectedChanges: []string{"a"}, | ||
| }, | ||
| "it should replace a file with the same size but not the same mtime": { | ||
| fixtureSrc: "src/file", | ||
| fixtureDst: "dst/same-size", | ||
| expectedChanges: []string{"a"}, | ||
| }, |
There was a problem hiding this comment.
These tests are impossible using on the CI as a git clone does not keep the modification time of the files. We would love to have src/file and dst/cp-file with two different modification time. But after a git clone on the CI, both files have the same modification time. It's the time of the git clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the commit b0bb006, I removed the failing tests as I want to have a CI that passes on
master. This PR is opened to work on restoring these failing tests.@Soulou I don't really see how we could do that in the CI. Do you have an idea? An idea would be to setup the test files at the beginning of the execution of the tests. So setting the modification time or the hard link in Go. What do you think?