Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nsqconsumer): add a configurable log level #978

Merged
merged 4 commits into from
Oct 30, 2024
Merged

feat(nsqconsumer): add a configurable log level #978

merged 4 commits into from
Oct 30, 2024

Conversation

SCedricThomas
Copy link
Contributor

@SCedricThomas SCedricThomas commented Oct 29, 2024 •
edited
Loading

  • Add a changelog entry in CHANGELOG.md

@SCedricThomas SCedricThomas self-assigned this Oct 29, 2024
@SCedricThomas SCedricThomas marked this pull request as ready for review October 29, 2024 16:14
EtienneM
EtienneM reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Please test it in dev

EtienneM
EtienneM approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@SCedricThomas SCedricThomas merged commit 6483e9a into master Oct 30, 2024
4 checks passed
@SCedricThomas SCedricThomas deleted the feat/add-log-level branch October 30, 2024 15:06
@SCedricThomas
Copy link
Contributor Author

STORY-1052

@SCedricThomas SCedricThomas mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees

@SCedricThomas SCedricThomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SCedricThomas @EtienneM