Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment of an unknown extension shouldn't have a match from the cache #236

Open
EtienneM opened this issue Mar 15, 2022 · 4 comments · May be fixed by #341
Open

Deployment of an unknown extension shouldn't have a match from the cache #236

EtienneM opened this issue Mar 15, 2022 · 4 comments · May be fixed by #341
Assignees
Labels
IST low Low Priority Issue

Comments

@EtienneM
Copy link
Member

EtienneM commented Mar 15, 2022

  git push scalingo master --force                
Enumerating objects: 47, done.
Counting objects: 100% (47/47), done.
Delta compression using up to 8 threads
Compressing objects: 100% (32/32), done.
Writing objects: 100% (47/47), 11.50 KiB | 11.50 MiB/s, done.
Total 47 (delta 15), reused 37 (delta 10)

Your deployment has been queued and is going to start…
<-- Start deployment of biniou -->
[...]
-----> Bundling additional extensions
toto
Checksums match. Fetching from cache.
[...]
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires PHP extension ext-toto * but it is missing from your system. Install or enable PHP's toto extension.
To enable extensions, verify that they are enabled in your .ini files:
- /app/vendor/php/etc/php.ini
- /app/vendor/php/etc/conf.d/apcu.ini
- /app/vendor/php/etc/conf.d/mongodb.ini
- /app/vendor/php/etc/conf.d/opcache.ini
- /app/vendor/php/etc/conf.d/redis.ini
You can also run `php --ini` in a terminal to see which files are used by PHP in CLI mode.
Alternatively, you can run Composer with `--ignore-platform-req=ext-toto` to temporarily ignore these required extensions.
Running update with --no-dev does not mean require-dev is ignored, it just means the packages will not be installed. If dev requirements are blocking the update you have to resolve those problems.
!     An error occurred during buildpack compilation
 !   Error deploying the application
!   → Invalid return code from buildpack

To ssh.osc-fr1.scalingo.com:biniou
 + e952c44...aac7467 master -> master (forced update)
  echo $?
0

Two things seem odd on this deployment logs:

  • When bundling the extension toto, the deployment logs contain Checksums match. Fetching from cache. But I would be surprised the extension toto is in the cache 😅
  • The returned code of the failed git push should not be 0 this is actually opened here: https://github.com/Scalingo/git-repository-core/issues/164

Reported by a customer: https://app.intercom.com/a/apps/w4oogu7s/inbox/inbox/all/conversations/12375700060102

@EtienneM EtienneM changed the title Return an error if the deployment failed due to unknown extension Deployment of an unknown extension shouldn't have a match from the cache Mar 15, 2022
@EtienneM EtienneM added low Low Priority Issue and removed high customer impact labels Mar 15, 2022
@Frzk Frzk linked a pull request Jul 11, 2023 that will close this issue
@Frzk Frzk self-assigned this Jul 11, 2023
@ipfaze
Copy link
Contributor

ipfaze commented Sep 22, 2023

@Frzk, Does the PR can be merged as @Soulou stated it was good to him?

@Frzk
Copy link
Contributor

Frzk commented Sep 25, 2023

@ipfaze: as you can see in the PR discussion, we want to add some unit-testing before merging.
So this will most probably take some time..

@ipfaze
Copy link
Contributor

ipfaze commented Sep 25, 2023

@Frzk, is there an issue that mention adding unit testing in this buildpack? Cause I don't find one 🙁

IMHO, we should set this issue as 🪦 stale and mention it in the issue about unit testing to keep track of this one.

@Frzk
Copy link
Contributor

Frzk commented Sep 26, 2023

@ipfaze: I confirm there currently is no issue directly related to unit testing. Please feel free to add one if you deem it useful.

@ipfaze ipfaze mentioned this issue Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IST low Low Priority Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants