-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite lib/pecl #341
base: master
Are you sure you want to change the base?
Rewrite lib/pecl #341
Conversation
af89ee9
to
4527a82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great, it's tricky to validate if it works correctly because of the lack of tests.
What do you think about using this PR to introduce some testing in the buildpack to prevent regressions?
Or maybe merge it and then prepare another PR with the ability to test the behavior?
What do you think would be best?
I'd be keen to:
WDYT? |
@Frzk Look good to me, but do you prefer this PR being merged or wait later? |
This is a complete rewrite of
lib/pecl
which originally contains code to install any PECL extension.While trying to reproduce #236, I dove into this code and thought it would greatly benefit from a rewrite. So, this PR:
set +e
that was put at some point,oci8
,yaml
andscoutapm
). This part is maybe the most arguable (see thephp::pecl::enable_pecl_extension
andphp::pecl::configure_extension
functions).Fixes #236